Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wlr-layout-ui: init at 1.4.7 #301557

Merged
merged 2 commits into from
Apr 18, 2024
Merged

wlr-layout-ui: init at 1.4.7 #301557

merged 2 commits into from
Apr 18, 2024

Conversation

bnlrnz
Copy link
Contributor

@bnlrnz bnlrnz commented Apr 4, 2024

Description of changes

Adding a Python-based package that provides a UI to configure monitor layouts for wlr based systems.
Link to the original Repo

This PR is related to Issue #298342

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

pkgs/by-name/wl/wlr-layout-ui/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/wl/wlr-layout-ui/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/wl/wlr-layout-ui/package.nix Outdated Show resolved Hide resolved
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits.

pkgs/by-name/wl/wlr-layout-ui/package.nix Show resolved Hide resolved
@Aleksanaa
Copy link
Member

Doesn't work:

=> ./result/bin/wlrlui 
Traceback (most recent call last):
  File "/nix/store/ablv4jas0wnyaya6qdcy00a11pjf07zp-wlr-layout-ui-1.4.3/bin/.wlrlui-wrapped", line 9, in <module>
    sys.exit(main())
             ^^^^^^
  File "/nix/store/ablv4jas0wnyaya6qdcy00a11pjf07zp-wlr-layout-ui-1.4.3/lib/python3.11/site-packages/wlr_layout_ui/__init__.py", line 56, in main
    load()
  File "/nix/store/ablv4jas0wnyaya6qdcy00a11pjf07zp-wlr-layout-ui-1.4.3/lib/python3.11/site-packages/wlr_layout_ui/screens.py", line 92, in load
    load_from_hyprctl()
  File "/nix/store/ablv4jas0wnyaya6qdcy00a11pjf07zp-wlr-layout-ui-1.4.3/lib/python3.11/site-packages/wlr_layout_ui/screens.py", line 53, in load_from_hyprctl
    modes = [Mode(*_parseMode(m)) for m in monitor["availableModes"]]
                                           ~~~~~~~^^^^^^^^^^^^^^^^^^
KeyError: 'availableModes'

Also you've not installed their desktop file (or create one yourself) https://github.com/fdev31/wlr-layout-ui/blob/main/files/wlr-layout-ui.desktop

@bnlrnz bnlrnz changed the title wlr-layout-ui: init at 1.4.3 wlr-layout-ui: init at 1.4.7 Apr 13, 2024
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also does this work for you? I can't test, possibly because of hyprland

pkgs/by-name/wl/wlr-layout-ui/package.nix Outdated Show resolved Hide resolved
patched version check, fixed postInstall
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort of works

@Aleksanaa Aleksanaa merged commit 23b0c99 into NixOS:master Apr 18, 2024
25 checks passed
@bnlrnz bnlrnz deleted the add-wlr-layout-ui branch April 19, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants