Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aircrack-ng: refactor #301105

Merged
merged 2 commits into from
Jun 20, 2024
Merged

aircrack-ng: refactor #301105

merged 2 commits into from
Jun 20, 2024

Conversation

thecaralice
Copy link
Contributor

Description of changes

Support other systems, check/installCheck, additional options

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@thecaralice thecaralice requested a review from wegank April 3, 2024 17:11
Aleksanaa
Aleksanaa reviewed Apr 10, 2024
View reviewed changes
pkgs/tools/networking/aircrack-ng/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/aircrack-ng/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/aircrack-ng/default.nix Outdated Show resolved Hide resolved
@thecaralice
Copy link
Contributor Author

I'm not sure about what's wrong with that CI job

@Kamillaova
Copy link
Contributor

@ofborg eval

@Kamillaova
Copy link
Contributor

Result of nixpkgs-review pr 301105 run on x86_64-linux 1

5 packages built:
  • aircrack-ng
  • airgeddon
  • dbmonster
  • wifite2
  • wifite2.dist

@thecaralice
aircrack-ng: refactor
ad7afa9 
Support other systems, add test dependencies etc.
@thecaralice
Copy link
Contributor Author

@ofborg eval

@siraben
Copy link
Member

siraben commented Jun 20, 2024

Result of nixpkgs-review pr 301105 run on x86_64-linux 1

5 packages built:
  • aircrack-ng
  • airgeddon
  • dbmonster
  • wifite2
  • wifite2.dist

@siraben siraben merged commit e0d3e54 into NixOS:master Jun 20, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wegank wegank Awaiting requested review from wegank

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thecaralice @Kamillaova @siraben @wegank @Aleksanaa