python3.pkgs.waitress-django/cudaPackages.saxpy/doc/test-runner: Use lib.fileset #300428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents unnecessary rebuilds when the default.nix is changed in any way.
This prevents unnecessary rebuilds when the default.nix is changed in any way.
dasJ
changed the title
github-actions
bot
added
6.topic: nixos
8.has: documentation
6.topic: testing
dasJ
changed the title
|
Nice! Though I'd recommend explicitly selecting the files to be included using |
|
Please regard this as just a nitpick: Many folders here are under your control, so it's possible refactor the folder structure to make filtering unnecessary. |
|
I don't see anything unusual going on, looks good to me.
|
ConnorBaker
approved these changes
Apr 1, 2024
SomeoneSerge
reviewed
Apr 1, 2024
| src = ./.; | ||
| src = pkgs.lib.fileset.toSource { | ||
| root = ./.; | ||
| fileset = pkgs.lib.fileset.difference ./. (pkgs.lib.fileset.unions [ ./common.nix ./default.nix ./shell.nix ]); |
There was a problem hiding this comment.
Side notes:
- I frequently find myself repeating some kind of a
fileFilterto discard the nix files. Makes me wonder if we want a shorthand for this... - Can unnest e.g. via
lib.pipe
There was a problem hiding this comment.
As mentioned earlier, I'd really recommend explicitly selecting the files to include:
Suggested change
| fileset = pkgs.lib.fileset.difference ./. (pkgs.lib.fileset.unions [ ./common.nix ./default.nix ./shell.nix ]); | |
| fileset = pkgs.lib.fileset.unions [ ... ]; |
That's going to be much more resilient.
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This causes
default.nixto be skipped when copying to the store to prevent rebuilds when reformatting the files (or changing them in any way that should not cause rebuilds).Should get rid of the rebuild in #299578.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.