Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cudaPackages.autoAddX: Deprecate #300321

Merged
merged 2 commits into from
Apr 10, 2024
Merged

cudaPackages.autoAddX: Deprecate #300321

merged 2 commits into from
Apr 10, 2024

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Mar 30, 2024 •
edited
Loading

Description of changes

Draft until the following have been merged:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jonringer jonringer force-pushed the deprecate-cuda-autoAddDriver branch from 5e8a430 to c40c1b2 Compare April 8, 2024 21:40
@jonringer jonringer marked this pull request as ready for review April 8, 2024 21:40
@jonringer jonringer force-pushed the deprecate-cuda-autoAddDriver branch 5 times, most recently from 1c5035d to a720219 Compare April 8, 2024 22:59
@jonringer jonringer force-pushed the deprecate-cuda-autoAddDriver branch 3 times, most recently from 8edba88 to b5b316a Compare April 10, 2024 01:40
@ConnorBaker
Copy link
Contributor

@jonringer looks good to me -- feel free to merge after ofborg-eval in CI finishes!

@jonringer jonringer force-pushed the deprecate-cuda-autoAddDriver branch from b5b316a to bfbd578 Compare April 10, 2024 15:28
@ConnorBaker
Copy link
Contributor

The formatter is displeased now?

@jonringer jonringer force-pushed the deprecate-cuda-autoAddDriver branch from bfbd578 to dadbcf9 Compare April 10, 2024 15:31
@jonringer
Copy link
Contributor Author

jonringer commented Apr 10, 2024 •
edited
Loading

Yea.... need to alter my vim setup to now run nixfmt on stuff

@ConnorBaker
Copy link
Contributor

Merging since CI passed. Thank you @jonringer :)

@ConnorBaker ConnorBaker merged commit 546930a into NixOS:master Apr 10, 2024
21 checks passed
@jonringer jonringer deleted the deprecate-cuda-autoAddDriver branch April 10, 2024 17:27
@jonringer
Copy link
Contributor Author

jonringer commented Apr 10, 2024 •
edited
Loading

After 2.5 years, finally checked this off of my "weirdness budget" list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConnorBaker ConnorBaker ConnorBaker approved these changes

@SomeoneSerge SomeoneSerge SomeoneSerge approved these changes

Assignees
No one assigned
Labels
6.topic: cuda 6.topic: nixos 8.has: changelog 8.has: clean-up 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12.approvals: 1
Projects
CUDA Team
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonringer @ConnorBaker @SomeoneSerge @wegank