Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scion-bootstrapper: init at 0.0.7 #299479

Merged

Conversation

MatthewCroughan
Copy link
Contributor

@MatthewCroughan MatthewCroughan commented Mar 27, 2024

Description of changes

Adds scion-bootstrapper to nixpkgs.

About tests

The tests require cacert openssl and scion in the nativeBuildInputs, but fail like this. Help would be appreciated if anyone wants to enable the tests.

Running phase: checkPhase
ok      github.com/netsec-ethz/bootstrapper/config      0.002s
t=2024-03-27T12:25:23+0000 lvl=eror msg="Signature verification failed: verifyTopologySignature" err="unable to validate certificate chain: exit status 1"
--- FAIL: TestVerify (0.02s)
--- FAIL: TestExtractSignerInfo (0.00s)
panic: interface conversion: interface {} is nil, not bool [recovered]
        panic: interface conversion: interface {} is nil, not bool

goroutine 10 [running]:
testing.tRunner.func1.2({0x629880, 0xc0000dbef0})
        /nix/store/bp39dh48cdqp89hk5mpdi1lxdf0mjl7x-go-1.22.1/share/go/src/testing/testing.go:1631 +0x24a
testing.tRunner.func1()
        /nix/store/bp39dh48cdqp89hk5mpdi1lxdf0mjl7x-go-1.22.1/share/go/src/testing/testing.go:1634 +0x377
panic({0x629880?, 0xc0000dbef0?})
        /nix/store/bp39dh48cdqp89hk5mpdi1lxdf0mjl7x-go-1.22.1/share/go/src/runtime/panic.go:770 +0x132
github.com/netsec-ethz/bootstrapper/fetcher.smimePk7out({0x6dcaa0, 0xc0000dbec0}, {0xc000020e80, 0x38}, {0xc000020ec0, 0x40})
        /build/source/fetcher/crypto_cmds.go:22 +0x10c
github.com/netsec-ethz/bootstrapper/fetcher.extractSignerInfo({0x6dcaa0, 0xc0000dbec0}, {0xc000020e80, 0x38}, {0xc000030c00, 0x29})
        /build/source/fetcher/scion_cppki_verify.go:170 +0xd7
github.com/netsec-ethz/bootstrapper/fetcher.TestExtractSignerInfo(0xc0000f7520)
        /build/source/fetcher/scion_cppki_verify_test.go:297 +0xa08
testing.tRunner(0xc0000f7520, 0x699150)
        /nix/store/bp39dh48cdqp89hk5mpdi1lxdf0mjl7x-go-1.22.1/share/go/src/testing/testing.go:1689 +0xfb
created by testing.(*T).Run in goroutine 1
        /nix/store/bp39dh48cdqp89hk5mpdi1lxdf0mjl7x-go-1.22.1/share/go/src/testing/testing.go:1742 +0x390
FAIL    github.com/netsec-ethz/bootstrapper/fetcher     0.026s
FAIL

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@sarcasticadmin
Copy link
Member

Result of nixpkgs-review pr 299479 run on x86_64-linux 1

1 package built:
  • scion-bootstrapper

Copy link
Member

@sarcasticadmin sarcasticadmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MatthewCroughan good call getting this one added in, it'll certainly be helpful to getting ASes online


vendorHash = "sha256-X4bOIvNlyQoAWOd3L6suE64KnlCV6kuE1ieVecVYWOw=";

doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest we keep this false until upstream figures out what to do about the checks:

@fricklerhandwerk fricklerhandwerk merged commit df7c06f into NixOS:master Mar 30, 2024
33 checks passed
@MatthewCroughan MatthewCroughan deleted the mc/scion-bootstrapper branch March 30, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants