Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openvpn3: 20 -> 21 #295058

Closed
wants to merge 1 commit into from
Closed

openvpn3: 20 -> 21 #295058

wants to merge 1 commit into from

Conversation

jfly
Copy link
Contributor

@jfly jfly commented Mar 11, 2024

Here's the changelog for openvpn3-linux: https://github.com/OpenVPN/openvpn3-linux/releases/tag/v21
I also upgraded openvpn3-core from 3.7.2 to 3.8.4: OpenVPN/openvpn3@release/3.7.2...release/3.8.4

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Here's the changelog for openvpn3-linux: https://github.com/OpenVPN/openvpn3-linux/releases/tag/v21
I also upgraded openvpn3-core from 3.7.2 to 3.8.4: OpenVPN/openvpn3@release/3.7.2...release/3.8.4
@jfly
Copy link
Contributor Author

jfly commented Mar 11, 2024

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • openvpn3

@ofborg ofborg bot requested review from SCOTT-HAMILTON and KFearsoff March 11, 2024 17:29
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Mar 11, 2024
Copy link
Contributor

@KFearsoff KFearsoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. LGTM!

An unfortunate caveat is that the OpenVPN3 part of the CLI is broken unless someone figures out the build (I couldn't) or until we get v22. Here is the tracking issue: #235986

@jfly
Copy link
Contributor Author

jfly commented Mar 25, 2024

It turns out there are DNS lookup domain related bugs in v21 that make it so that I don't want to use it myself. Between that and the glib issues, I guess it's best for nixpkgs to just wait for openvpn v22. Closing this PR.

@jfly jfly closed this Mar 25, 2024
@jfly jfly deleted the update-openvpn3 branch March 25, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants