-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deltatouch: init at 1.4.0 #289642
deltatouch: init at 1.4.0 #289642
Conversation
Lomiri in NixOS is 1-2 PRs away so I wanna give this a look, will give a review when I have some spare time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to Nixpkgs! Haven't tried to build yet, but here are some initial notes.
Also to consider:
finalAttrs
style instead ofrec
style. Just grep Nixpkgs for some examples.- Can we do without needing to copy-paste libraries into the build & output tree? Either patching the CMake script to link against system-supplied versions, or at least replacing the ones in the output tree with symlinks to the originals?
242f926
to
5944619
Compare
There is no need for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to also merge #289215 first to update libdeltachat. But it is not a blocker, deltatouch works with old libdeltachat too. |
I think the version should be |
There is a "prepare 1.4.0" commit. The tag is missing. cc @lk108 did you forgot to push the tag or will you tag some later commit with 1.4.0? |
I'm sorry, the tag should be there now. |
So now the title of this PR is valid, it is 1.4.0 |
0d84c51
to
7c8b4f3
Compare
7c8b4f3
to
d1c883f
Compare
d1c883f
to
42a50aa
Compare
You don't see the necessary icons, quote from link2xt above: |
There is a "settings" icon in the top right corner, you don't see it because need to configure icons with qt5ct as described in the top post. |
Actually, the "+" icon is used to set up a new account |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well with the hints. I didn't test translations etc though.
Selecting the Suru icon theme in qt5ct was not necessary btw.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is fine with you, considering there was some uncertainty about the patch.
6eba76c
to
6462571
Compare
I tested, still works. |
Co-authored-by: matthewcroughan <[email protected]> Co-authored-by: Cosima Neidahl <[email protected]>
6462571
to
1d093cb
Compare
Rebased another time because of dbc967d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of nixpkgs-review pr 289642
run on x86_64-linux 1
1 package built:
- deltatouch
LGTM! Thanks for sticking through with all the reviews and back n forth!
Description of changes
This is an initial commit for DeltaTouch Delta Chat client.
It is a Delta Chat client for Ubuntu Touch, available at OpenStore.
Things done
Built on x86_64-linux (Arch Linux with Nix installed via Determinate Nix Installer).
Having correct icons requires installing qt5ct in the profile and selecting "suru" icon theme.
Tested by running:
This is how it looks like:
It is possible to configure account, send and receive messages. File selection dialog currently does not work outside of Lomiri desktop environment and I am not running the whole Lomiri, but it is usable anyway.