Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linuxPackages.rtl8188eus: support kernel 6.7 #286083

Merged

Conversation

nix-julia
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from moni-dz February 3, 2024 15:52
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Feb 3, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3384

@SuperSandro2000 SuperSandro2000 changed the title linuxPackages.rtl8188eus: supprot kernel 6.7 linuxPackages.rtl8188eus: support kernel 6.7 Feb 6, 2024
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please fix the typo in the commit message

pkgs/os-specific/linux/rtl8188eus-aircrack/default.nix Outdated Show resolved Hide resolved
@nix-julia nix-julia force-pushed the update-linuxPackages.rtl8188eus branch 4 times, most recently from f42a78c to 49f0244 Compare February 7, 2024 13:40
@SuperSandro2000
Copy link
Member

@ofborg build linuxKernel.packages.linux_6_7.rtl8188eus-aircrack

@nix-julia nix-julia closed this Feb 10, 2024
@nix-julia nix-julia reopened this Feb 10, 2024
@nix-julia
Copy link
Contributor Author

sorry that i closed the PR by mistake

@ofborg ofborg bot requested a review from moni-dz February 11, 2024 23:02
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash merge

@nix-julia nix-julia force-pushed the update-linuxPackages.rtl8188eus branch from 0991a4a to 4b809a7 Compare February 12, 2024 14:10
@SuperSandro2000 SuperSandro2000 merged commit 452e6c8 into NixOS:master Feb 12, 2024
19 checks passed
@nix-julia nix-julia deleted the update-linuxPackages.rtl8188eus branch February 13, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants