wgnlpy: init at 0.1.5 #281134
Merged
wgnlpy: init at 0.1.5 #281134
+42
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
zeuner
reviewed
Jan 27, 2024
|
Result of 4 packages built:
|
|
@ofborg build python311Packages.wgnlpy python312Packages.wgnlpy |
| "wgnlpy" | ||
| "wgnlpy.nlas" | ||
| ]; | ||
|
|
There was a problem hiding this comment.
Suggested change
| doCheck = false; # no tests | |
There was a problem hiding this comment.
Not recommended if checkPhase doesn't bring much overhead, as this is more likely to be ignored even after an update with tests added.
There was a problem hiding this comment.
Well, Python tests don't really run without pytest or another test runner. In my opinion it is good to document why the package does not run tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.