Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luaPackages: init some neovim packages #275841

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

mrcjkb
Copy link
Member

@mrcjkb mrcjkb commented Dec 21, 2023

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@mrcjkb mrcjkb marked this pull request as draft December 21, 2023 15:17
@mrcjkb
Copy link
Member Author

mrcjkb commented Dec 21, 2023

Result of nixpkgs-review pr 275841 run on x86_64-linux 1

1 package marked as broken and skipped:
  • lua54Packages.neotest
24 packages built:
  • lua51Packages.commons-nvim
  • lua51Packages.funnyfiles-nvim
  • lua51Packages.fzf-lua
  • lua51Packages.neotest
  • lua51Packages.nvim-nio
  • lua52Packages.commons-nvim
  • lua52Packages.funnyfiles-nvim
  • lua52Packages.fzf-lua
  • lua52Packages.neotest
  • lua52Packages.nvim-nio
  • lua53Packages.commons-nvim
  • lua53Packages.funnyfiles-nvim
  • lua53Packages.fzf-lua
  • lua53Packages.neotest
  • lua53Packages.nvim-nio
  • lua54Packages.commons-nvim
  • lua54Packages.funnyfiles-nvim
  • lua54Packages.fzf-lua
  • lua54Packages.nvim-nio
  • luajitPackages.commons-nvim
  • luajitPackages.funnyfiles-nvim
  • luajitPackages.fzf-lua
  • luajitPackages.neotest
  • luajitPackages.nvim-nio

@mrcjkb
Copy link
Member Author

mrcjkb commented Dec 21, 2023

I will have to leave this as draft until #272647 hits master, because rocks.nvim depends on fidget.nvim.

@mrcjkb
Copy link
Member Author

mrcjkb commented Dec 22, 2023

Strange that this didn't show any failures, given the missing dependency.

@mrcjkb
Copy link
Member Author

mrcjkb commented Apr 1, 2024

nixpkgs-review on x86_64-linux:

1 package marked as broken and skipped:
lua54Packages.neotest

49 packages built:
lua51Packages.commons-nvim lua51Packages.funnyfiles-nvim lua51Packages.fzf-lua lua51Packages.lua-utils-nvim lua51Packages.neotest lua51Packages.nvim-nio lua51Packages.rocks-config-nvim lu
a51Packages.rocks-dev-nvim lua51Packages.rocks-git-nvim lua51Packages.rocks-nvim lua52Packages.commons-nvim lua52Packages.funnyfiles-nvim lua52Packages.fzf-lua lua52Packages.lua-utils-nvi
m lua52Packages.neotest lua52Packages.nvim-nio lua52Packages.rocks-config-nvim lua52Packages.rocks-dev-nvim lua52Packages.rocks-git-nvim lua52Packages.rocks-nvim lua53Packages.commons-nvi
m lua53Packages.funnyfiles-nvim lua53Packages.fzf-lua lua53Packages.lua-utils-nvim lua53Packages.neotest lua53Packages.nvim-nio lua53Packages.rocks-config-nvim lua53Packages.rocks-dev-nvi
m lua53Packages.rocks-git-nvim lua53Packages.rocks-nvim lua54Packages.commons-nvim lua54Packages.funnyfiles-nvim lua54Packages.fzf-lua lua54Packages.lua-utils-nvim lua54Packages.nvim-nio 
lua54Packages.rocks-config-nvim lua54Packages.rocks-dev-nvim lua54Packages.rocks-git-nvim lua54Packages.rocks-nvim luajitPackages.commons-nvim luajitPackages.funnyfiles-nvim luajitPackage
s.fzf-lua luajitPackages.lua-utils-nvim luajitPackages.neotest luajitPackages.nvim-nio luajitPackages.rocks-config-nvim luajitPackages.rocks-dev-nvim luajitPackages.rocks-git-nvim luajitP
ackages.rocks-nvim

@mrcjkb mrcjkb marked this pull request as ready for review April 1, 2024 19:30
@mrcjkb
Copy link
Member Author

mrcjkb commented Apr 1, 2024

@teto fidget.nvim has reached master, so this is ready now.

@teto teto merged commit 7ab5913 into NixOS:master Apr 2, 2024
33 checks passed
@teto
Copy link
Member

teto commented Apr 2, 2024

pretty cool ty.

@mrcjkb mrcjkb deleted the luapackages branch April 2, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants