Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-23.11] zfs: default disable zfs_dmu_offset_next_sync to avoid data corruption #270445

Commits on Nov 27, 2023

  1. zfs: default disable zfs_dmu_offset_next_sync to avoid data corruption

    This helps mitigate a data corruption bug. This was previously defaulted
    to zero prior to upstream commit
    05b3eb6d232009db247882a39d518e7282630753, and it is already a tunable,
    so doing this seems safe. Initially data corruption was thought to be
    introduced with v2.2, but further upstream investigation currently
    believes that changes in v2.2 only exacerbated the issue that already
    existed.
    
    A longer-term fix is likely to be
    openzfs/zfs#15571, though that is not yet
    merged. The zfs_2_1 package has already backported that, so do not apply
    the tunable default change there.
    
    Positioning of `extraPatches` is to avoid merge conflicts with
    NixOS#269097.
    
    Patch is nearly identical to the [Gentoo][1] patch, but better patch
    formatting.
    
    See openzfs/zfs#11900
    See openzfs/zfs#15526
    
    [1]: https://gitweb.gentoo.org/repo/gentoo.git/tree/sys-fs/zfs-kmod/files/zfs-kmod-2.2.1-Disable-zfs_dmu_offset_next_sync-tunable-by-default.patch
    
    (cherry picked from commit 9670ddc)
    amarshall authored and adamcstephens committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    9f2dc97 View commit details
    Browse the repository at this point in the history