Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoPatchelfHook: add patchelfFlags option #256525

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Conversation

K900
Copy link
Contributor

@K900 K900 commented Sep 21, 2023

Description of changes

This may be useful to enable things like NixOS/patchelf#521 on a per-package basis.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Mindavi
Copy link
Contributor

Mindavi commented Sep 28, 2023

Diff looks good to me.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 28, 2023
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 30, 2023
@K900 K900 merged commit 03fddbf into NixOS:staging Oct 2, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants