Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pista: init at unstable-2023-02-20 #184768

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

benjajaja
Copy link

@benjajaja benjajaja commented Aug 2, 2022

a simple {bash, zsh} prompt for programmers

Description of changes

https://github.com/nerdypepper/pista

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@smancill
Copy link
Contributor

Please add yourself as a maintainer in a separate commit, and then add the package in a second commit.

Copy link
Contributor

@smancill smancill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reword your commit as "pista: init at unstable-2021-12-15"

pkgs/misc/pista/default.nix Outdated Show resolved Hide resolved
pkgs/misc/pista/default.nix Outdated Show resolved Hide resolved
pkgs/misc/pista/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@smancill smancill changed the title add pista pista: init at unstable-2021-12-15 Aug 19, 2022
@benjajaja benjajaja requested review from smancill and removed request for smancill August 31, 2022 16:41
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
pkgs/by-name/pi/pista/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pi/pista/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pi/pista/package.nix Outdated Show resolved Hide resolved
@smancill
Copy link
Contributor

Since this is a new package, it should be put now into pkgs/by-name/pi/pista/package.nix, and removed from all-packages.nix.

@smancill smancill changed the title pista: init at unstable-2021-12-15 pista: init at unstable-2023-02-20 Aug 24, 2024
@benjajaja
Copy link
Author

@smancill Thanks for the review, suggestions applied! I had already done the move from all-packages.nix to by-name/....

Copy link
Contributor

@smancill smancill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change to fix the build on Darwin.

pkgs/by-name/pi/pista/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pi/pista/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pi/pista/package.nix Show resolved Hide resolved
a simple {bash, zsh} prompt for programmers

Co-authored-by: Sebastián Mancilla <[email protected]>
@benjajaja
Copy link
Author

Thanks again!

@smancill
Copy link
Contributor

Result of nixpkgs-review pr 184768 run on x86_64-darwin 1

1 package built:
  • pista

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants