Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/pipewire: use absolute path for jack libs #136475

Merged
merged 1 commit into from
Sep 3, 2021
Merged

nixos/pipewire: use absolute path for jack libs #136475

merged 1 commit into from
Sep 3, 2021

Conversation

Artturin
Copy link
Member

@Artturin Artturin commented Sep 2, 2021 •
edited
Loading

Motivation for this change

Closes #110468
Thanks @mm--

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 2, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 2, 2021
@Artturin Artturin changed the title nixos:pipewire: use absolute path for jack libs nixos/pipewire: use absolute path for jack libs Sep 2, 2021
fufexan
fufexan approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my machine, fixes the issue.

@Artturin Artturin merged commit 45b7c5b into NixOS:master Sep 3, 2021
@Artturin Artturin deleted the pipewirejackldpath branch September 3, 2021 13:36
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2021

The process '/usr/bin/git' failed with exit code 1

@github-actions github-actions bot mentioned this pull request Sep 3, 2021
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2021

Successfully created backport PR #136585 for release-21.05.

@jtojnar jtojnar mentioned this pull request Jul 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kranzes Kranzes Kranzes approved these changes

@fufexan fufexan fufexan approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
3 participants
@Artturin @fufexan @Kranzes