Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add prettier to dev shell #1586

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add prettier to dev shell #1586

wants to merge 1 commit into from

Conversation

mschwaig
Copy link
Member

No description provided.

crertel
crertel approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@crertel crertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, see comment. We may already have some of this for you.

flake.nix Outdated Show resolved Hide resolved
@mschwaig
Copy link
Member Author

Actually if npm manages what version of prettier is used, then adding the one from nixpkgs to the command line might not be a good idea, so I removed that from this PR again.

I got the idea from the log of the failing format check here: https://github.com/NixOS/nixos-homepage/actions/runs/11843965454/job/33006101651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crertel crertel crertel approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mschwaig @crertel