Meson fixes for msys2 builds #11809
Merged
Meson fixes for msys2 builds #11809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
new-cli
|
Thanks! I think long term we'll want everything to work with fewer symlinks (for the build) and native symlinks (for tests), but this is good for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Building Nix using mingw64, using Meson.
Context
I've been using the Makefile to build using mingw64. With these changes (and #11808) I can now use Meson.
One core difference is that symlinks are very important to both the Meson infrastructure (due to build-utils-meson) and the Meson builds (e.g. things pointing to nix.exe) - so you have to change the Windows settings in order to build. This was not needed using Make.