Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #20 #51

Closed
wants to merge 1 commit into from
Closed

Fix #20 #51

wants to merge 1 commit into from

Conversation

Freed-Wu
Copy link

Fix #20, network error

@Freed-Wu Freed-Wu force-pushed the netease-cloud-music branch from e990164 to fbc4650 Compare July 12, 2023 16:17
@Freed-Wu
Copy link
Author

Fixed

Freed-Wu added a commit to Freed-Wu/nur-packages that referenced this pull request Jul 12, 2023
@Freed-Wu
Copy link
Author

@linyinfeng

Freed-Wu added a commit to Freed-Wu/nur-packages that referenced this pull request Jul 13, 2023
@linyinfeng
Copy link
Member

We need a newer version of nixpkgs to support curlOptsList.

nix run github:NixOS-CN/flakes/pull/51/head#netease-cloud-music:

error:
       … while calling the 'listToAttrs' builtin

         at /nix/store/bfllm0im5z34n4v84zvip0kwy6vwl2yz-source/lib/attrsets.nix:139:5:

          138|   filterAttrsRecursive = pred: set:
          139|     listToAttrs (
             |     ^
          140|       concatMap (name:

       … while calling the 'concatMap' builtin

         at /nix/store/bfllm0im5z34n4v84zvip0kwy6vwl2yz-source/lib/attrsets.nix:140:7:

          139|     listToAttrs (
          140|       concatMap (name:
             |       ^
          141|         let v = set.${name}; in

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: function 'anonymous lambda' called with unexpected argument 'curlOptsList'

       at /nix/store/bfllm0im5z34n4v84zvip0kwy6vwl2yz-source/pkgs/build-support/fetchurl/default.nix:40:1:

           39|
           40| { # URL to fetch.
             | ^
           41|   url ? ""

Seems the update workflow https://github.com/NixOS-CN/flakes/blob/main/.github/workflows/update.yml is broken since 2023-04-29 @Ninlives.

@Freed-Wu Freed-Wu force-pushed the netease-cloud-music branch from fbc4650 to e7b0a29 Compare July 13, 2023 13:23
Freed-Wu added a commit to Freed-Wu/nur-packages that referenced this pull request Jul 13, 2023
@Freed-Wu
Copy link
Author

We need a newer version of nixpkgs to support curlOptsList.

OK, I have changed curlOptsList to curlOpts.

@Freed-Wu Freed-Wu force-pushed the netease-cloud-music branch 2 times, most recently from 9c33a19 to fdd54c3 Compare July 13, 2023 14:25
Freed-Wu added a commit to Freed-Wu/nur-packages that referenced this pull request Jul 13, 2023
@Freed-Wu Freed-Wu force-pushed the netease-cloud-music branch from fdd54c3 to c53c092 Compare July 14, 2023 04:34
@Freed-Wu Freed-Wu force-pushed the netease-cloud-music branch from c53c092 to 7ad5281 Compare July 14, 2023 05:21
Freed-Wu added a commit to Freed-Wu/nur-packages that referenced this pull request Jul 14, 2023
Freed-Wu added a commit to Freed-Wu/nur-packages that referenced this pull request Jul 14, 2023
@linyinfeng
Copy link
Member

linyinfeng commented Jul 14, 2023

We need a newer version of nixpkgs to support curlOptsList.

OK, I have changed curlOptsList to curlOpts.

Actually, I mean, we need to fix the update workflow or do nix flake update manually instead of using the old nixpkgs...
And other packages will also need to be tested and fixed after an update.

But currently, nixos-cn/flakes is poorly maintained. @Ninlives even proposed that we should deprecate and archive it in #nixos_zhcn:nichi.co:

(2023-07-13T15:29+08:00)
mlatus (@Ninlives)
    我有点想把 nixos-cn/flakes archive 掉,实在没啥人维护(
    大家觉得呢
    感觉就去 nur 好了
Yinfeng
    维护度确实太低了
mlatus
    愿意维护就到 nixpkgs 去
    这个 flake 感觉比较鸡肋
    反正 sops-template 也 upstream 了
Yinfeng
    archive 掉得先把包整出去
mlatus
    有啥包大家还要的认领一下?
(然而之后并没有人认领,可见目前并没有人在维护这个仓库……)

So I recommend keeping the package in your own flake/nur. It needs some work to bring this repository back to normal, or in the worst situation, this repository will be deprecated and archived.

@Freed-Wu
Copy link
Author

OK. Can this package be uploaded to nixos/nixpkgs? If not, I'll save this package in my NUR. When this repository have new changes, please ping me 😄

@Freed-Wu Freed-Wu closed this Jul 14, 2023
@Freed-Wu Freed-Wu deleted the netease-cloud-music branch July 14, 2023 07:54
@linyinfeng
Copy link
Member

OK. Can this package be uploaded to nixos/nixpkgs? If not, I'll save this package in my NUR. When this repository have new changes, please ping me smile

Yes, you can upstream it to nixpkgs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Network error running netease music
2 participants