Rust CI

Rewrite networking to have proper round-robin across instances and retries #537

Sign in to view logs

GitHub Actions / clippy failed Sep 9, 2024 in 0s

clippy

6 errors

Details

Results

Message level	Amount
Internal compiler error	0
Error	6
Warning	0
Note	0
Help	0

Versions

rustc 1.81.0 (eeb90cda1 2024-09-04)
cargo 1.81.0 (2dbb1af80 2024-08-20)
clippy 0.1.81 (eeb90cd 2024-09-04)

Annotations

Check failure on line 369 in pkcs11/src/backend/login.rs

github-actions / clippy

this block may be rewritten with the `?` operator

error: this block may be rewritten with the `?` operator
   --> pkcs11/src/backend/login.rs:367:5
    |
367 | /     if user.password.is_none() {
368 | |         return None;
369 | |     }
    | |_____^ help: replace it with: `user.password.as_ref()?;`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
    = note: `-D clippy::question-mark` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::question_mark)]`

Check failure on line 489 in pkcs11/src/backend/key.rs

github-actions / clippy

useless conversion to the same type: `backend::Error`

error: useless conversion to the same type: `backend::Error`
   --> pkcs11/src/backend/key.rs:489:24
    |
489 |             return Err(err.into());
    |                        ^^^^^^^^^^ help: consider removing `.into()`: `err`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check failure on line 138 in pkcs11/src/backend/encrypt.rs

github-actions / clippy

useless conversion to the same type: `backend::Error`

error: useless conversion to the same type: `backend::Error`
   --> pkcs11/src/backend/encrypt.rs:138:13
    |
138 |             err.into()
    |             ^^^^^^^^^^ help: consider removing `.into()`: `err`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `-D clippy::useless-conversion` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`

Check failure on line 369 in pkcs11/src/backend/login.rs

github-actions / clippy

this block may be rewritten with the `?` operator

error: this block may be rewritten with the `?` operator
   --> pkcs11/src/backend/login.rs:367:5
    |
367 | /     if user.password.is_none() {
368 | |         return None;
369 | |     }
    | |_____^ help: replace it with: `user.password.as_ref()?;`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
    = note: `-D clippy::question-mark` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::question_mark)]`

Check failure on line 489 in pkcs11/src/backend/key.rs

github-actions / clippy

useless conversion to the same type: `backend::Error`

error: useless conversion to the same type: `backend::Error`
   --> pkcs11/src/backend/key.rs:489:24
    |
489 |             return Err(err.into());
    |                        ^^^^^^^^^^ help: consider removing `.into()`: `err`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check failure on line 138 in pkcs11/src/backend/encrypt.rs

github-actions / clippy

useless conversion to the same type: `backend::Error`

error: useless conversion to the same type: `backend::Error`
   --> pkcs11/src/backend/encrypt.rs:138:13
    |
138 |             err.into()
    |             ^^^^^^^^^^ help: consider removing `.into()`: `err`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `-D clippy::useless-conversion` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`

View more details on GitHub Actions