Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update time crate #200

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Update time crate #200

merged 2 commits into from
Aug 16, 2024

Conversation

mmerklinger
Copy link
Contributor

This PR updates the time crate.

mmerklinger and others added 2 commits August 2, 2024 11:57
- Remove dead code
- Add `Error` implementation to `InitializationError` and use the
display implemenatation in the logs
@sosthene-nitrokey
Copy link
Contributor

The dead code warnings appeared because now the debug implementation being used is not considered enough I think.
I instead implemented and used display so that the warnings are silenced and the errors are nicer.

@mmerklinger mmerklinger marked this pull request as ready for review August 2, 2024 13:27
@ansiwen ansiwen merged commit cb311f6 into main Aug 16, 2024
3 checks passed
@ansiwen ansiwen deleted the bump-time-crate branch August 16, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants