Add config file including all options #172
Conversation
|
The test will conflict with #165 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
==========================================
+ Coverage 90.81% 90.88% +0.07%
==========================================
Files 31 31
Lines 6410 6450 +40
==========================================
+ Hits 5821 5862 +41
+ Misses 589 588 -1 ☔ View full report in Codecov by Sentry. |
p11nethsm.example.conf
Outdated
| # Optional log level, acceptable values are Trace, Debug, Info, Warn and Error | ||
| log_level: Debug | ||
|
|
||
| # Each "slot" represents a NetHSM server |
There was a problem hiding this comment.
Actually, it’s a set of servers with the same users and keys (or at least a common subset), isn’t it? Not sure if there is a preferred term for that setup. Maybe “NetHSM cluster”?
There was a problem hiding this comment.
Yeah a slot represent a cluster of NetHSM that can be accessed with the same credentials.
https://docs.nitrokey.com/nethsm/pkcs11-setup#instances
There was a problem hiding this comment.
This was taken verbatim from the docs.
I Will fix it both here and there.
There was a problem hiding this comment.
Ah that's my bad. I should add that the slot name comes from PKCS#11 where it's like a card reader or HSM port.
There was a problem hiding this comment.
Once this is merged I will udpate it also in the docs.
sosthene-nitrokey
force-pushed
the
document-format
branch
2 times, most recently
from
ab8ed2d to
6a8e20c
Compare
sosthene-nitrokey
force-pushed
the
document-format
branch
from
6a8e20c to
02fafff
Compare
Match the documentation in Nitrokey/nethsm-pkcs11#172
Match the documentation in Nitrokey/nethsm-pkcs11#172
This PR adds an
p11nethsm.example.confincluding and explaining all the options. It also adds a unit test that checks all the values of this file once parsed.