ci: Use GitHub App authentication to checkout nillion repo #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwolski2
requested review from
navasvarela,
Jmgr,
manel1874,
jcabrero,
pablojhl and
nilmemo
jwolski2
changed the title
jwolski2
changed the title
This commit switches the `build.yml` workflow over to use GitHub App tokens to checkout the nillion repo (private) instead of relying on PATs, which expire and have to be manually rotated. Instead, I created a GitHub App named "Nillion Repo" at the org-level. I gave the app read-only access to the nillion repo. And I added the app's ID and private key to the nada-dsl repo: * As a variable: `NILLION_REPO_APP_ID` * And as a secret: `NILLION_REPO_APP_PRIVATE_KEY`
jwolski2
force-pushed
the
chore/use-github-app-auth
branch
from
f37db65
to
8cad30d
Compare
navasvarela
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This commit switches the
build.ymlworkflow over to use GitHub App tokens to checkout the nillion repo (private) instead of relying on PATs, which expire and have to be manually rotated.Instead, I created a GitHub App named "Nillion Repo" at the org-level. I gave the app read-only access to the nillion repo. And I added the app's ID and private key to the nada-dsl repo:
NILLION_REPO_APP_IDNILLION_REPO_APP_PRIVATE_KEYMerge requirement checklist