Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
inner
tochild
(producer
was also considered, butchild
is more idiomatic in the context of an AST)inner_type
tocontained_type
in compound types (we are now storing more than one type in compound types) and removedinner_type
from operationsto_type
toto_mir
is_scalar
andis_literal
(will be used in a follow up PR)Note that this doesn't break the MIR. We will do the necessary changes in a follow up PR, as well as in another PR in the main nillion repo so that it is able to interpret the changes.
You can review each commit separately instead of all changes at once if you want, should be easier to read.
Merge requirement checklist