Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: various renames and fixes #54

Merged
merged 1 commit into from
Nov 15, 2024
Merged

chore: various renames and fixes #54

merged 1 commit into from
Nov 15, 2024

Conversation

Jmgr
Copy link
Member

@Jmgr Jmgr commented Nov 14, 2024

Changes

  • removes a few class attributes definition (they should be instance attributes instead)
  • renames inner to child (producer was also considered, but child is more idiomatic in the context of an AST)
  • renames inner_type to contained_type in compound types (we are now storing more than one type in compound types) and removed inner_type from operations
  • renames to_type to to_mir
  • adds is_scalar and is_literal (will be used in a follow up PR)

Note that this doesn't break the MIR. We will do the necessary changes in a follow up PR, as well as in another PR in the main nillion repo so that it is able to interpret the changes.

You can review each commit separately instead of all changes at once if you want, should be easier to read.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Backwards compatibility analysis completed (if applicable). "Will this change require recompilation and upload of user programs?"

@Jmgr Jmgr changed the title chore: various renames and fixes chore!: various renames and fixes Nov 14, 2024
@Jmgr Jmgr marked this pull request as ready for review November 14, 2024 14:00
@Jmgr Jmgr requested a review from a team as a code owner November 14, 2024 14:00
nada_dsl/ast_util.py Outdated Show resolved Hide resolved
nada_dsl/ast_util.py Outdated Show resolved Hide resolved
nada_dsl/ast_util.py Outdated Show resolved Hide resolved
nada_dsl/ast_util.py Outdated Show resolved Hide resolved
@Jmgr
Copy link
Member Author

Jmgr commented Nov 14, 2024

Sorry I had to make another change to this PR. As we discussed in Slack making breaking changes to the MIR now is not ideal, and we will also need to rename inner_type in a lot of places, so for now we are going to keep internal changes only.

@Jmgr Jmgr changed the title chore!: various renames and fixes chore: various renames and fixes Nov 14, 2024
@Jmgr Jmgr enabled auto-merge (squash) November 15, 2024 11:05
@Jmgr Jmgr merged commit c9ad05a into main Nov 15, 2024
4 checks passed
@Jmgr Jmgr deleted the chore/renaming-fixes branch November 15, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants