Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for Python builtin sum #25

Merged
merged 1 commit into from
Sep 24, 2024
Merged

feat: Add support for Python builtin sum #25

merged 1 commit into from
Sep 24, 2024

Conversation

navasvarela
Copy link

@navasvarela navasvarela commented Sep 23, 2024 •
edited
Loading

Changes

Adds support for Python builtin sum operation by allowing integers in __radd__ for numeric values.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Backwards compatability analysis completed (if applicable). "Will this change require recompilation and upload of user programs?"

@navasvarela navasvarela requested a review from a team as a code owner September 23, 2024 12:50
lumasepa
lumasepa requested changes Sep 24, 2024
View reviewed changes
nada_dsl/compile_test.py Outdated Show resolved Hide resolved
@navasvarela navasvarela force-pushed the feat/builtin-sum-python branch from 0dde74c to 02476f8 Compare September 24, 2024 07:22
@navasvarela navasvarela force-pushed the feat/builtin-sum-python branch from 02476f8 to 56f20eb Compare September 24, 2024 08:56
@navasvarela navasvarela merged commit efbedc2 into main Sep 24, 2024
2 checks passed
@navasvarela navasvarela deleted the feat/builtin-sum-python branch September 24, 2024 11:56
@navasvarela navasvarela mentioned this pull request Oct 21, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablojhl pablojhl pablojhl approved these changes

@lumasepa lumasepa lumasepa approved these changes

@Jmgr Jmgr Jmgr approved these changes

@manel1874 manel1874 Awaiting requested review from manel1874 manel1874 is a code owner automatically assigned from NillionNetwork/lcx

@jcabrero jcabrero Awaiting requested review from jcabrero jcabrero is a code owner automatically assigned from NillionNetwork/lcx

@nilmemo nilmemo Awaiting requested review from nilmemo nilmemo is a code owner automatically assigned from NillionNetwork/lcx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@navasvarela @Jmgr @lumasepa @pablojhl