feat: Add Docker setup #9
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberglot
commented
Oct 24, 2024
| @@ -11,14 +11,14 @@ | |||
| "test": "jest", | |||
| "format": "prettier --write \"**/*.{js,ts,json,md}\"", | |||
| "prepare": "husky", | |||
| "lint": "eslint . --fix", | |||
| "lint": "eslint src --fix", | |||
There was a problem hiding this comment.
For some reason, it was trying to lint the code generated in dist/ ?
cyberglot
commented
Oct 24, 2024
Comment on lines
+36
to
+45
| rl.question(dockerMessage, (answer) => { | ||
| rl.close(); | ||
| const yesOrNo = answer.trim() || "nillion-quickstart"; | ||
| if (/y|yes|n|no/.test(yesOrNo)) { | ||
| resolve(yesOrNo === "y" || yesOrNo === "yes"); | ||
| } else { | ||
| console.log("Using default: no Docker container."); | ||
| resolve(false); | ||
| } | ||
| }); |
There was a problem hiding this comment.
I'd like to replace this part of the code with something more robust like prompt.js or inquirer.js!
cyberglot
commented
Oct 24, 2024
| @@ -19,3 +19,5 @@ export const installDependencies = async () => { | |||
| }); | |||
| console.log("Dependencies installed successfully."); | |||
| }; | |||
|
|
|||
| export const installRepoPackage = installDependencies("npm", ["install"]); | |||
There was a problem hiding this comment.
I abstracted the commands passed in, but didn't use it in the end. Maybe I should undo this work, idk.
cyberglot
commented
Oct 24, 2024
| <%= it.projectName %>: | ||
| restart: always | ||
| environment: | ||
| - WATCHPACK_POLLING=true |
There was a problem hiding this comment.
This is for Windows users, but I am not sure if it works because I don't have a Windows machine.
cyberglot
commented
Oct 24, 2024
|
|
||
| EXPOSE 3000 | ||
| ENV PORT=3000 | ||
| CMD ["sh"] |
There was a problem hiding this comment.
In some case, users may want to run commands inside the Docker container, now they easily can.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Docker setup for users having problems meeting the requirements to run a nillion app.