empty list returned without sorting #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberg
reviewed
Aug 27, 2024
src/listwiz/sorting.py
Outdated
| @@ -21,7 +21,7 @@ def merge_sort(l): | |||
| sorted_list | |||
| """ | |||
| # If there is a single item, the list is already sorted, return. | |||
| if len(l) == 1: | |||
| if 0 <= len(l) <= 1: | |||
There was a problem hiding this comment.
Suggested change
| if 0 <= len(l) <= 1: | |
| if len(l) <= 1: |
I think it would be clearer to delete this, since the length cannot be negative.
(since it is a small change, one can just apply it. Often I would just do that as a maintainer)
|
Of course there should be a test :-) After all, there was already a stub. |
Nikoleta-v3
approved these changes
Aug 29, 2024
|
Thank you gertingold 😄 @seberg should we fix the merge conflict and merge? |
Yap, looks all good to me, thanks. Can't even find a nitpick :). |
|
Thanks @gertingold. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to handle empty lists like lists of length 1 and to return the list unmodified. This solution should fix #8