Fixed the stageless_progress example. Added a little more clarity to the examples: stageless_progress and progress_tracking
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This example did not work as we would like. `ProgressPlugin` did not affect the loading status of assets in any way. As well as minor changes to better understand the essence of what is happening.
NiklasEi
reviewed
Jul 23, 2022
There was a problem hiding this comment.
iyes_progress not continuing the state in the stageless example was a workaround for #54. I realize now how that broke the whole idea of the example, thank you for pointing that out!
Letting iyes_progress continue the state is correct, but will break without the manually tracked task. Could you add the following to the top comment on the stageless example please:
/// NOTE: If you do not track any `iyes_progress` tasks manually, you need to let the `LoadingState`
/// handle the state transition! See [#54](https://github.com/NiklasEi/bevy_asset_loader/issues/54) for more info.
hopefully that will prevent more users from running into that bug. Ideally we would properly fix it, but I still think my last comment on the issue is the right call.
|
I will consider all your wishes in the near future |
|
Since I am preparing for the Bevy 0.8 release and would like to include this, I quickly fixed it up myself. Thank you for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will ask you to read the comments to the commits, so as not to duplicate them here.
Thanks.