Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature aplad 9194 #18

Merged
merged 6 commits into from
Aug 23, 2023
Merged

Feature aplad 9194 #18

merged 6 commits into from
Aug 23, 2023

Conversation

Umeshsp22
Copy link
Collaborator

Description

  1. Build functionally to collect error threshold of row_dq rules
  2. correct input_count issue when dataframe with zero records supplied
  3. Corrected the target_table_name table issue when zero data quality rules supplied

Related Issue

  1. [FEATURE] Add functionality to collect error percentage of row_dq rules in stats table #15 (comment)
  2. [BUG] input_count has not been set properly #16 (comment)
  3. [BUG] target_table_name key error #17 (comment)

Motivation and Context

persisting the error threshold of the row_dq rules for future statistical or dash boarding

How Has This Been Tested?

  1. Tested using local environment setup & corrected the cross functionality

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (78c4759) 100.00% compared to head (d2218e4) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         1343      1369   +26     
=========================================
+ Hits          1343      1369   +26     
Files Changed Coverage Δ
spark_expectations/core/context.py 100.00% <100.00%> (ø)
spark_expectations/core/expectations.py 100.00% <100.00%> (ø)
spark_expectations/sinks/utils/writer.py 100.00% <100.00%> (ø)
spark_expectations/utils/regulate_flow.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@asingamaneni asingamaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asingamaneni asingamaneni merged commit a13208a into main Aug 23, 2023
6 checks passed
@asingamaneni asingamaneni deleted the feature-aplad-9194 branch August 23, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants