Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support if dataframe of instance pyspark.sql.connect.dataframe.Dataframe is passed as input #110

Conversation

diviteja-g
Copy link
Contributor

support if dataframe of instance pyspark.sql.connect.dataframe.Dataframe is passed as input

Description

Spark Expectations currently fail on databricks runtime 14 and above when dataframe of instance pyspark.sql.connect.dataframe.Dataframe is passed as input.

Updated logic to check for both dataframe instances as either of it can be passed depending on how dataframe is created (read from table, output of a query, read from files)

Related Issue

#106

Motivation and Context

How Has This Been Tested?

Uploaded wheel file generated to Databricks cluster runtime versions 13, 14, & 15 and ran spark expectations job

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@stampthecoder
Copy link

stampthecoder commented Sep 19, 2024

@diviteja-g this is exactly what we need! The current version lacks this pull requests dataframe types for spark connect. Is this project still active?

Copy link
Collaborator

@asingamaneni asingamaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution

@asingamaneni asingamaneni merged commit d7db1bb into Nike-Inc:main Oct 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants