Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Implement the ability to select all roles in the role selection screen with "a" or "all" #473

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

its-mirus-lu
Copy link

Per feature request #472 this PR contains code to implement the logic to prompt users for "a" or "all" in the role selection screen to select all roles available to them.

Description

The following changes were implemented

In main.py, the _get_user_int_selections_many was modified:

  1. Modified 'Selections (comma separated)' to 'Selections (comma separated; specify "A" for all profiles)' in _get_user_int_selections_many
  2. Modified logic in _get_user_int_selections_many method to detect whether 'a' or 'all' is specified in the user inputs
  3. Populate selections set in _get_user_int_selections_many method with range of values from min_int to max_int

Two test cases were added to validate the implementation:

  • def test_choose_roles_app_select_all(self, mock):
  • def test_choose_roles_app_select_all_a(self, mock):

Related Issue

Implements feature request: #472

Motivation and Context

This PR implements a feature enhancement to improve/simplify usability of the tool.

How Has This Been Tested?

Run locally with code changes in my forked repo

Screenshots (if appropriate):

Here is what the prompt looks like:
Prompt

And here is the result:
Result

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@its-mirus-lu its-mirus-lu changed the title Feature: Implement the ability to select all roles in the role selection screen with "a" or "all" #472 Feature: Implement the ability to select all roles in the role selection screen with "a" or "all" Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant