Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ignore permission error due to most likely being caused by shared clusters #97

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

stikkireddy
Copy link
Collaborator

This resolves the permissions issues in brickflow on shared clusters.

Description

This

Related Issue

Resolves issue #31 and #96

How Has This Been Tested?

Unit test has been included

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (548b6cb) 90.27% compared to head (9e5a103) 90.32%.

Files Patch % Lines
brickflow/engine/task.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   90.27%   90.32%   +0.05%     
==========================================
  Files          22       22              
  Lines        3361     3381      +20     
==========================================
+ Hits         3034     3054      +20     
  Misses        327      327              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…at it is a user code error, rather than framework error.
@stikkireddy stikkireddy marked this pull request as ready for review February 12, 2024 19:05
Copy link
Collaborator

@asingamaneni asingamaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asingamaneni asingamaneni merged commit 000dc06 into main Feb 12, 2024
4 checks passed
@asingamaneni asingamaneni deleted the fix/issue-31-shared-clusters branch February 12, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants