Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Improve logic for local deployment of PythonScript #168

Merged
merged 13 commits into from
Oct 18, 2024

Conversation

mikita-sakalouski
Copy link
Contributor

@mikita-sakalouski mikita-sakalouski commented Oct 14, 2024

Improving the logic of getting project root in Workspace based on yaml config, instead of project name.

Description

Reuse MultiManager to get brick flow project root inside DataBricks

Related Issue

Motivation and Context

How Has This Been Tested?

Rerun all tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mikita-sakalouski mikita-sakalouski changed the title Fix: Improve logic for local deployment of PythonScript [fix] Improve logic for local deployment of PythonScript Oct 18, 2024
Copy link
Collaborator

@newfront newfront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to go.

@newfront newfront merged commit f133723 into Nike-Inc:main Oct 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants