Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow parameters #158

Merged
merged 19 commits into from
Sep 17, 2024

Conversation

mikita-sakalouski
Copy link
Contributor

Description

  1. Added parameters attribute for class Workflow, reuse JobsParameters class for type expected in this
  2. Adjusted Job creation to pass workflow.parameters
  3. Adjusted tests

Related Issue

#157

Motivation and Context

Setup workflow parameters and push them to tasks through variables.

How Has This Been Tested?

Adjusted existing tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 96.07843% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.53%. Comparing base (35d0824) to head (9ad2fa6).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
brickflow/codegen/databricks_bundle.py 94.11% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
+ Coverage   90.33%   91.53%   +1.19%     
==========================================
  Files          22       22              
  Lines        3384     4076     +692     
==========================================
+ Hits         3057     3731     +674     
- Misses        327      345      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@asingamaneni asingamaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asingamaneni asingamaneni merged commit 63011dc into Nike-Inc:main Sep 17, 2024
2 checks passed
@mikita-sakalouski mikita-sakalouski deleted the feat/workflow_parameters branch September 17, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants