Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add WorkflowTaskDependencySensor #110

Conversation

maxim-mityutko
Copy link
Contributor

@maxim-mityutko maxim-mityutko commented Apr 19, 2024

Description

Leverage Databricks API to retrieve the state of the specific task within the workflow run. The code mostly inherits from the WorkflowDependencySensor.

Related Issue

#109

Motivation and Context

In many cases it's more benificial to put a dependency on a specific task within the workflow instead the workflow itself. It reduces the wait time of the downstream workflows.

How Has This Been Tested?

Unit tests + workflow in Databricks with a success sensor and a failed sensor

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@maxim-mityutko maxim-mityutko marked this pull request as ready for review April 19, 2024 17:48
Copy link
Collaborator

@asingamaneni asingamaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asingamaneni asingamaneni merged commit 2b70616 into Nike-Inc:main May 6, 2024
2 checks passed
shwen-gine pushed a commit to shwen-gine/brickflow that referenced this pull request May 9, 2024
* WorkflowTaskDependencySensor

* update docs

* fix request params

* add `get_job_id` to utils

* update utils and tests

---------

Co-authored-by: Maxim Mityutko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants