Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bump plugin dependencies for pydantic 2.x #102

Conversation

maxim-mityutko
Copy link
Contributor

@maxim-mityutko maxim-mityutko commented Mar 23, 2024

Closes #95

Description

Bump versions of airflow and snowflake packages to ensure compatibility with libraries that require pydantic >= 2.x.x

Related Issue

#95

Motivation and Context

Certain libraries require pydantic >= 2.x, and while brickflow itself is compatible with it, when plugins are enabled the older snowflake and airflow dependencies for pydantic 1.x

How Has This Been Tested?

Built-in tests; bumped library's versions in the real life project and use library that requires pydantic 2.x

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.32%. Comparing base (6ba515b) to head (e2e3e50).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   90.32%   90.32%           
=======================================
  Files          22       22           
  Lines        3381     3381           
=======================================
  Hits         3054     3054           
  Misses        327      327           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@asingamaneni asingamaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asingamaneni asingamaneni merged commit c3bfa6c into Nike-Inc:main Mar 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Transitive dependency on pydantic < 2.0.0 due to snowflake==0.5.1
2 participants