bug fix: Add CPU write access flag #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This bug brings up the issue that the existing test cases do not cover the basic scenarios. |
The issue is that there are no existing test cases at all 😅. but yeah one of the encoder functions needed this flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last commit #90, I just removed the write access flag from the texture, but didn't change everything involving this texture to read-only, which caused a lot of problems, so instead of obsessing about whether or not the texture is writable, just add
D3D11_CPU_ACCESS_WRITEto it to quickly fix the problems caused by the previous bug.