Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/record cli #82

Merged
merged 9 commits into from
Oct 2, 2024

Conversation

MilkClouds
Copy link
Contributor

@MilkClouds MilkClouds commented Sep 18, 2024

I added CLI executable to record given window name or monitor index. This CLI executable will work as example of this library's application.

Features

  • get window_name or monitor_index
  • get cursor_capture and draw_border
  • get path
  • show up FPS of capture(which is NOT recorded video files fps)
  • graceful exit with ctrl+c
  • automatically detect window / monitor 's height/width and save into video file

Some minor concerns

  • Is it okay to maintain the CLI's Cargo dependencies together with the main project's dependencies?

@MilkClouds
Copy link
Contributor Author

MilkClouds commented Sep 18, 2024

And I'm thinking about adding logic to automatically set the bitrate adaptively according to width, height.

@raags
Copy link

raags commented Oct 2, 2024

This is very useful! Can you also add the ability to select the Window to capture? i.e. enumerate all open windows, and list the idx + title for the user to choose. Also, I think rect should be part of the library to be able to capture a window.

@raags
Copy link

raags commented Oct 2, 2024

Actually I just realised triggering GraphicsCapturePicker is all that's needed

@NiiightmareXD
Copy link
Owner

Hey, I don't know how did I missed this PR I review it when I got home, thanks.

@NiiightmareXD NiiightmareXD merged commit 24fae7d into NiiightmareXD:main Oct 2, 2024
2 checks passed
@NiiightmareXD
Copy link
Owner

Looks good, thanks.

@raags
Copy link

raags commented Oct 3, 2024

@NiiightmareXD thanks for merging, any plans to implement GraphicsCapturePicker?

@NiiightmareXD
Copy link
Owner

@NiiightmareXD thanks for merging, any plans to implement GraphicsCapturePicker?

Yes, but implementing that in win32 apps is somewhat weird and you need to have an active window, which I don't know what is the way to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants