Relax lifetime restrictions on as_raw_buffer
, as_raw_nopadding_buffer
, and save_as_image
for windows_capture::frame::FrameBuffer
#41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We probably intend these lifetimes to look like:
which is equivalent to letting the lifetimes be inferred I think.
Hope this PR helps, let me know if there are any changes you'd like, thanks!
For some context, this was preventing me from writing a function like:
and I would get an error like:
Essentially when I call
frame_buffer.as_raw_buffer()
, it tries to borrow it for the lifetime of'fb
above, which is probably not what we want (I just wanna borrow it just for this statement, not for the whole'fb
lifetime).