Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove G5 from status page header #3515

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

Navid200
Copy link
Collaborator

@Navid200 Navid200 commented Jun 3, 2024

This is what the status page will look like after this:
Screenshot_20240603-075232 Outdated - please see next post

I forgot about this one in my previous PR: #3506

@Navid200 Navid200 marked this pull request as draft June 3, 2024 12:02
@Navid200
Copy link
Collaborator Author

Navid200 commented Jun 3, 2024

Screenshot_20240603-084816 Outdated Please see my last post.

@Navid200 Navid200 marked this pull request as ready for review June 3, 2024 12:51
@Navid200
Copy link
Collaborator Author

Navid200 commented Jun 3, 2024

I have changed the heading to only say Dexcom considering the subheading has the details.
have removed OB1 from the subheading because I don't think the average user knows what that refers to.
I hope I have not overlooked anything.

@jamorham
Copy link
Collaborator

I don't want to make changes that could potentially include trademarks unless absolutely necessary. I'm fine with removing G5 though.

@Navid200
Copy link
Collaborator Author

Will this be OK?

Screenshot_20240612-085432

@Navid200
Copy link
Collaborator Author

These headings have been fluid ever since One came along. Since then, there have been even more.
And there will be more coming soon.
So, my hope is that we can use a heading that remains intact as new devices come along.
So, I hope you accept the update I have made to this PR to address your concern.

If not, please let me know and I will just remove G5.

Copy link
Collaborator

@jamorham jamorham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is fine now

@jamorham jamorham merged commit bce64b4 into NightscoutFoundation:master Jun 25, 2024
1 check passed
@Navid200 Navid200 deleted the Navid_2024_06_03 branch June 25, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants