-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missed reading alert on by default #3380
Conversation
Test: I installed this on a phone with no xDrip on it. The missed reading alert was enabled. |
Considering the two scenarios I have described in my first post, I believe a safer approach is to have the alert enabled by default to avoid a possible disaster as opposed to avoid an annoyance. |
Test2: I uninstalled xDrip. Then, installed the latest Nightly before this PR. I did not open the missed reading alert page. This means anyone who is currently using xDrip who has never visited the missed reading alert page will have the alert automatically enabled after they update their xDrip to this PR. I then disabled the missed reading alert. |
I don't really want to enable this by default, it is annoying because if someone is out of range of their phone then the phone starts alarming. |
@jamorham Then, they can disable it. There are thousands of people who are not even aware that this alert exists. No one is obligated to keep it active. Are you saying if this PR is approved, it will not allow one to permanently disable the setting? |
I have this alert enabled. I need to know I have no readings when I am sleep. I don't want to find out when I wake up that I have had no readings for hours. You are correct that if I walk away from the phone for longer than 30 minutes, this alert will trigger. We have two options. We can leave this disabled by default or enable it by default. Each one of those two options has a pro and a con. The con for leaving it disabled could cause a disaster that I personally don't want us to be responsible for if we can do something about it. The con for enabling it is that if one walks away from their phone, this alert will trigger. |
People ask is there a way for me to know that I have had no readings for a while? |
If you merge this, I will announce it on facebook and explain that it will trigger if they walk away so that no one is surprised. |
@jamorham The missed reading alert has a checkbox that says Would you please reconsider this? |
The missed reading alert is disabled by default intentionally. I don't think it should be enabled by default. Users who want to use it can enable it. |
Very well. Thanks for the response. I will try to highlight this in the guide so that hopefully no one will ever be surprised when it is too late. |
The missed reading alert is disabled by default. Anyone who needs it must enable it.
Whether we set the setting to on or off by default, a group of users need to change it to their preference.
If we set the default to enabled, the group that needs to change it is the group who is annoyed by the missed reading alert.
If we set the default to disabled, the group that needs to change it is the group that could face a disaster if they don't!
That would be a parent waking up in the morning and finding out that they have had no reading from their child for hours.
Please also note that when we face the database corruption, the sensor could stop working. If the missed reading alert is disabled, the user will have no idea until they check.