Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed reading alert on by default #3380

Closed

Conversation

Navid200
Copy link
Collaborator

@Navid200 Navid200 commented Mar 9, 2024

The missed reading alert is disabled by default. Anyone who needs it must enable it.

Whether we set the setting to on or off by default, a group of users need to change it to their preference.
If we set the default to enabled, the group that needs to change it is the group who is annoyed by the missed reading alert.
If we set the default to disabled, the group that needs to change it is the group that could face a disaster if they don't!
That would be a parent waking up in the morning and finding out that they have had no reading from their child for hours.

Please also note that when we face the database corruption, the sensor could stop working. If the missed reading alert is disabled, the user will have no idea until they check.

@Navid200
Copy link
Collaborator Author

Navid200 commented Mar 9, 2024

Test:

I installed this on a phone with no xDrip on it. The missed reading alert was enabled.

@Navid200
Copy link
Collaborator Author

Navid200 commented Mar 9, 2024

Considering the two scenarios I have described in my first post, I believe a safer approach is to have the alert enabled by default to avoid a possible disaster as opposed to avoid an annoyance.

@Navid200
Copy link
Collaborator Author

Test2:

I uninstalled xDrip. Then, installed the latest Nightly before this PR. I did not open the missed reading alert page.
I then installed this PR over it. Checking the missed reading alert, the alert is enabled.

This means anyone who is currently using xDrip who has never visited the missed reading alert page will have the alert automatically enabled after they update their xDrip to this PR.

I then disabled the missed reading alert.
I then, installed this PR again over it. Checking the missed reading alert, I can see that it is still disabled.
This means that if an xDrip user intentionally disables the alert, installing this version over will not enable the alert.

@Navid200 Navid200 requested a review from jamorham May 10, 2024 19:43
@jamorham
Copy link
Collaborator

I don't really want to enable this by default, it is annoying because if someone is out of range of their phone then the phone starts alarming.

@Navid200
Copy link
Collaborator Author

Navid200 commented May 22, 2024

@jamorham Then, they can disable it.

There are thousands of people who are not even aware that this alert exists. No one is obligated to keep it active.

Are you saying if this PR is approved, it will not allow one to permanently disable the setting?

@Navid200
Copy link
Collaborator Author

Navid200 commented May 22, 2024

I have this alert enabled. I need to know I have no readings when I am sleep. I don't want to find out when I wake up that I have had no readings for hours.

You are correct that if I walk away from the phone for longer than 30 minutes, this alert will trigger.
The phone has no means of discovering if I am near or not. So, I accept this is a limitation of this alert.

We have two options. We can leave this disabled by default or enable it by default. Each one of those two options has a pro and a con.

The con for leaving it disabled could cause a disaster that I personally don't want us to be responsible for if we can do something about it.

The con for enabling it is that if one walks away from their phone, this alert will trigger.
Then, they can disable it if they choose to. Then, if the next day they wake up and find out that they had no readings for 8 hours and got no alert, we did our part. It was their choice that caused the problem.

@Navid200
Copy link
Collaborator Author

People ask is there a way for me to know that I have had no readings for a while?
When I tell them about the missed reading alert, they thank me.
I will keep doing that.
My worry is those who are not aware and suffer and never ask.

@Navid200
Copy link
Collaborator Author

If you merge this, I will announce it on facebook and explain that it will trigger if they walk away so that no one is surprised.

@Navid200
Copy link
Collaborator Author

@Navid200
Copy link
Collaborator Author

Navid200 commented Jul 7, 2024

@jamorham The missed reading alert has a checkbox that says all day.
If you disable it, it will give you the option of choosing a time period. So, you can enable it only for when you are sleeping knowing that you won't walk away from the phone, unless you have the habit of sleep walking, in which case an alert will be a blessing as well. :o)

Would you please reconsider this?

@Navid200
Copy link
Collaborator Author

Navid200 commented Jul 7, 2024

There are people who actually find it quite useful when the user walks away from their phone!

Screenshot 2024-07-07 171024

@jamorham
Copy link
Collaborator

The missed reading alert is disabled by default intentionally. I don't think it should be enabled by default. Users who want to use it can enable it.

@Navid200
Copy link
Collaborator Author

Very well. Thanks for the response.

I will try to highlight this in the guide so that hopefully no one will ever be surprised when it is too late.

@Navid200 Navid200 closed this Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants