Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added inactive days button to the G6 status page #2856

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Navid200
Copy link
Collaborator

@Navid200 Navid200 commented May 26, 2023

There are individuals who order extra G6 transmitters so that they have a replacement ready. The result is that they are always using older transmitters than they have to.
At times, we see transmitters that still have many days left, yet, the battery dies.
But, to confirm that the transmitter is old, we have to ask them to enable engineering mode.

This PR will let us see what we need with no need to enable engineering mode.
After this PR, inactive days is shown below transmitter days as shown below.
Screenshot_20230526-163850

@jamorham
Copy link
Collaborator

I think this is likely going to be a confusing extra bit of information and there was a batch of transmitters that didn't have good batteries but for a very long time now I have never seen this problem even with almost at the end of shelf life transmitters being used. If the battery dies there is nothing we can do so I don't think it really matters to know what the inactive days might have been as we will have low battery stats recorded if battery was the issue.

@Navid200
Copy link
Collaborator Author

Navid200 commented Jun 16, 2023

Please consider this scenario:

Someone posts on facebook asking for advice because their G6 has stopped working.
We go through everything and we suspect the problem is battery.
Considering the battery hardly ever dies before 110 days unless you have put the transmitter on shelf for a very long time, it helps to confirm that before deciding what the next step should be.

If the battery is dead when the transmitter has been sitting on the shelf for a very long time, it is pointless to contact Dexcom.
If the battery is dead when the inactive days is only a month or two, it makes sense to contact Dexcom because this would be a very unlikely scenario of battery dying too early.

We always tell users that engineering mode is only for testing.
But, this isn't really testing xDrip. This is verifying what the number of inactive days is.
Having it visible on the status page by default removes the need for us to ask the user to enable engineering mode.

Please reconsider.
I hate to say this. But, if you insist, I am OK adding a button to show it only if the user taps on the transmitter days.

@Navid200 Navid200 marked this pull request as draft August 26, 2023 22:55
@Navid200 Navid200 marked this pull request as ready for review September 15, 2023 02:04
@Navid200
Copy link
Collaborator Author

Navid200 commented Sep 15, 2023

I have added a blank entry at the bottom of the status page to serve as a button.
Placing the button on the existing transmitter days line would locate the button adjacent to the existing button that updates the battery voltages. As the lines are very close, it would be difficult for someone who does not have thin fingers to press the button they intend to press.

This is what the status page look like after this PR.
Screenshot_20230914-220116

Tapping on the new button will bring up a new line showing inactive days as shown below.
Screenshot_20230914-221214

In a few seconds, the new line disappears and the status page looks as it did before.
On my test phone, it takes about 10 seconds.

How can I make the delay a constant in time independent of the hardware?

@Navid200
Copy link
Collaborator Author

I have tested this on an old Android 8 phone, on an Android 11 Motorola Stylus and on An Android 13 Pixel 6a.
They all show the inactive days for about 10 seconds.

@Navid200 Navid200 changed the title Added inactive days to the G6 status page Added inactive days button to the G6 status page Sep 15, 2023
@Navid200
Copy link
Collaborator Author

The blank row now is really blank.
Screenshot_20230923-092638

Tapping it, will replace the empty row with inactive days.
Screenshot_20230923-092730

Is there any chance the timer could interfere with the collector wake?

@Navid200
Copy link
Collaborator Author

The timer is about 50 seconds if you stay on the status page.
If you leave the status page, the counter stops. When you return to the status page, inactive days will still be visible until the count finishes.

@Navid200 Navid200 marked this pull request as draft November 15, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants