Sourcery Starbot ⭐ refactored NicolasFlandrois/Stardate #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SourceryAI
commented
Nov 11, 2023
Comment on lines
-24
to
-35
| def ask_integer(message: str, range, error_message: str = ""): | ||
| def ask_integer(self, range, error_message: str = ""): | ||
| """ | ||
| This function's purpose is to ask and verify an Integer. | ||
| """ | ||
| var = None | ||
| while True: | ||
| try: | ||
| var = int(input(message)) | ||
| var = int(input(self)) | ||
| if var in range: | ||
| return var | ||
| raise | ||
|
|
There was a problem hiding this comment.
Function Compute.ask_integer refactored with the following changes:
- The first argument to instance methods should be
self(instance-method-first-arg-name) - Remove unreachable code (
remove-unreachable-code)
Comment on lines
-42
to
+47
| def leapyr(year: int): | ||
| def leapyr(self): | ||
| """" | ||
| This function defines if the year is | ||
| a Leap year (366 days) | ||
| or a Normal year (365 days). | ||
| Then it will to the variable n the value of 366 or 365, accordingly. | ||
| """ | ||
| if year % 400 == 0 or (year % 4 == 0 and year % 100 != 0): | ||
| n = 366 | ||
| # print("The year is a Leap year.\n") | ||
|
|
||
| else: | ||
| n = 365 | ||
| # print("The year is a normal year.\n") | ||
|
|
||
| return n | ||
| return 366 if self % 400 == 0 or self % 4 == 0 and self % 100 != 0 else 365 |
There was a problem hiding this comment.
Function Compute.leapyr refactored with the following changes:
- The first argument to instance methods should be
self(instance-method-first-arg-name) - Replace if statement with if expression (
assign-if-exp) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
This removes the following comments ( why? ):
# print("The year is a Leap year.\n")
# print("The year is a normal year.\n")
Comment on lines
-64
to
+54
| def sdconvert(t): | ||
| def sdconvert(self): |
There was a problem hiding this comment.
Function Compute.sdconvert refactored with the following changes:
- The first argument to instance methods should be
self(instance-method-first-arg-name)
Comment on lines
-78
to
+80
| def sdtranslate(sd): | ||
| def sdtranslate(self): |
There was a problem hiding this comment.
Function Compute.sdtranslate refactored with the following changes:
- The first argument to instance methods should be
self(instance-method-first-arg-name) - Move assignment closer to its usage within a block [×2] (
move-assign-in-block) - Remove unnecessary casts to int, str, float or bool (
remove-unnecessary-cast) - Merge append into list declaration [×2] (
merge-list-append)
| def menu(convert, translate): | ||
| def menu(self, translate): |
There was a problem hiding this comment.
Function View.menu refactored with the following changes:
- The first argument to instance methods should be
self(instance-method-first-arg-name) - Swap if/else branches (
swap-if-else-branches) - Remove unnecessary else after guard condition (
remove-unnecessary-else)
Comment on lines
-73
to
+76
| dlist = [] | ||
| dlist.append(Compute.ask_integer("Earth Year? (YYYY format) ", | ||
| range(-10000000, 10000000))) | ||
| dlist = [ | ||
| Compute.ask_integer( | ||
| "Earth Year? (YYYY format) ", range(-10000000, 10000000) | ||
| ) | ||
| ] |
There was a problem hiding this comment.
Function View.ask_date refactored with the following changes:
- Merge append into list declaration (
merge-list-append)
Comment on lines
-101
to
+106
| def show_date(earthdate): | ||
| def show_date(self): | ||
| """ | ||
| Displays a date object, in a User Experience readable format. | ||
| """ | ||
| return earthdate()[1] | ||
| return self()[1] |
There was a problem hiding this comment.
Function View.show_date refactored with the following changes:
- The first argument to instance methods should be
self(instance-method-first-arg-name)
Comment on lines
-107
to
+113
| def show_stardate(stardate, date): | ||
| def show_stardate(self, date): | ||
| """ | ||
| Displays Date's Stardate. | ||
| """ | ||
| print("Earthdate : ", date) | ||
| print("\nStardate : ", stardate) | ||
| print("\nStardate : ", self) |
There was a problem hiding this comment.
Function View.show_stardate refactored with the following changes:
- The first argument to instance methods should be
self(instance-method-first-arg-name)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run: