Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(evm): commit temporary state on precompile start, avoiding bug stemming from uncommitted, dirty journal entries in the EVM StateDB #2086

Merged
merged 17 commits into from
Oct 24, 2024

revert cacheCtx since Revert fails txs automatically

7cc070b
Select commit
Loading
Failed to load commit list.
Merged

fix(evm): commit temporary state on precompile start, avoiding bug stemming from uncommitted, dirty journal entries in the EVM StateDB #2086

revert cacheCtx since Revert fails txs automatically
7cc070b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Oct 23, 2024 in 1s

73.95% of diff hit (target 0.00%)

View this Pull Request on Codecov

73.95% of diff hit (target 0.00%)

Annotations

Check warning on line 79 in x/evm/errors.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/errors.go#L77-L79 

Added lines #L77 - L79 were not covered by tests

Check warning on line 87 in x/evm/errors.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/errors.go#L81-L87 

Added lines #L81 - L87 were not covered by tests

Check warning on line 106 in x/evm/evmtest/erc20.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/evmtest/erc20.go#L104-L106 

Added lines #L104 - L106 were not covered by tests

Check warning on line 130 in x/evm/evmtest/tx.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/evmtest/tx.go#L128-L130 

Added lines #L128 - L130 were not covered by tests

Check warning on line 170 in x/evm/evmtest/tx.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/evmtest/tx.go#L170 

Added line #L170 was not covered by tests

Check warning on line 251 in x/evm/evmtest/tx.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/evmtest/tx.go#L249-L251 

Added lines #L249 - L251 were not covered by tests

Check warning on line 257 in x/evm/evmtest/tx.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/evmtest/tx.go#L255-L257 

Added lines #L255 - L257 were not covered by tests

Check warning on line 279 in x/evm/evmtest/tx.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/evmtest/tx.go#L279 

Added line #L279 was not covered by tests

Check warning on line 291 in x/evm/evmtest/tx.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/evmtest/tx.go#L291 

Added line #L291 was not covered by tests

Check warning on line 218 in x/evm/keeper/erc20.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/keeper/erc20.go#L217-L218 

Added lines #L217 - L218 were not covered by tests

Check warning on line 230 in x/evm/keeper/erc20.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/keeper/erc20.go#L229-L230 

Added lines #L229 - L230 were not covered by tests

Check warning on line 235 in x/evm/keeper/erc20.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/keeper/erc20.go#L234-L235 

Added lines #L234 - L235 were not covered by tests

Check warning on line 292 in x/evm/keeper/msg_server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/keeper/msg_server.go#L292 

Added line #L292 was not covered by tests

Check warning on line 353 in x/evm/keeper/msg_server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/keeper/msg_server.go#L353 

Added line #L353 was not covered by tests

Check warning on line 372 in x/evm/keeper/msg_server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/keeper/msg_server.go#L372 

Added line #L372 was not covered by tests

Check warning on line 381 in x/evm/keeper/msg_server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/keeper/msg_server.go#L381 

Added line #L381 was not covered by tests

Check warning on line 385 in x/evm/keeper/msg_server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/keeper/msg_server.go#L385 

Added line #L385 was not covered by tests

Check warning on line 71 in x/evm/precompile/funtoken.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/precompile/funtoken.go#L70-L71 

Added lines #L70 - L71 were not covered by tests

Check warning on line 184 in x/evm/precompile/precompile.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/precompile/precompile.go#L183-L184 

Added lines #L183 - L184 were not covered by tests

Check warning on line 190 in x/evm/precompile/precompile.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/precompile/precompile.go#L188-L190 

Added lines #L188 - L190 were not covered by tests

Check warning on line 194 in x/evm/precompile/precompile.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/precompile/precompile.go#L193-L194 

Added lines #L193 - L194 were not covered by tests

Check warning on line 461 in x/evm/statedb/statedb.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/statedb/statedb.go#L461 

Added line #L461 was not covered by tests

Check warning on line 468 in x/evm/statedb/statedb.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/statedb/statedb.go#L468 

Added line #L468 was not covered by tests
View more details on Codecov