Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(evm): add oracle precompile #2056
feat(evm): add oracle precompile #2056
Changes from 4 commits
8425c78
54be57d
3f820b3
87744c1
9ef7dd9
9cbd553
6752ed5
c84eb37
de62b92
ad136c7
2584155
51f49fe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider refining the gas calculation in
RequiredGas
methodThe
RequiredGas
method currently returns a constantgethparams.TxGas
, which is a fixed cost for transactions that do not create contracts. To ensure accurate gas estimation for this precompile, consider calculating the gas based on the actual computational complexity of thequeryExchangeRate
method.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Enhance the error message for unsupported methods
The error message
"invalid method called with name \"%s\""
could be improved to provide more guidance to the user. Consider listing the supported methods in the error to aid in debugging.Apply this diff to enhance the error message:
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Wrap errors with context in
queryExchangeRate
methodTo improve debuggability, consider wrapping the errors returned from called functions with additional context. This provides clearer information about where and why a failure occurred.
Apply this diff to wrap the errors:
📝 Committable suggestion