Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(evm-rpc-backend): Add testnetwork tests using a node with a real RPC backend #2037

Closed
wants to merge 36 commits into from

Conversation

Unique-Divine
Copy link
Member

@Unique-Divine Unique-Divine commented Sep 13, 2024

commit a4a2e65
Author: Unique-Divine <[email protected]>
Date:   Fri Sep 13 08:09:44 2024 +0900

    fix: panic on nil gethcore.Log passed to bloom constructor

commit 180c146
Author: Unique-Divine <[email protected]>
Date:   Fri Sep 13 07:34:50 2024 +0900

    refactor: remove unnecessary code

commit bd43152
Author: Unique-Divine <[email protected]>
Date:   Fri Sep 13 07:15:53 2024 +0900

    refactor: remove unused

commit 452d47e
Merge: 8441dde 60167ca
Author: Unique-Divine <[email protected]>
Date:   Fri Sep 13 05:04:59 2024 +0900

    Merge branch 'main' into ud/evm-events

commit 8441dde
Author: Unique-Divine <[email protected]>
Date:   Fri Sep 13 05:04:33 2024 +0900

    chore: changelog

commit 5bcf6a7
Author: Unique-Divine <[email protected]>
Date:   Fri Sep 13 04:57:38 2024 +0900

    remove rpc/backend mocks and add test setup

commit b971a9a
Author: Unique-Divine <[email protected]>
Date:   Fri Sep 13 04:57:07 2024 +0900

    refactor(evm): use typed event for tx logs and message emission

commit 255305b
Author: Unique-Divine <[email protected]>
Date:   Fri Sep 13 02:14:47 2024 +0900

    chore: linter

commit 2f8b1e4
Author: Unique-Divine <[email protected]>
Date:   Fri Sep 13 02:09:10 2024 +0900

    chore: stopping point

commit 1df1e9d
Author: Unique-Divine <[email protected]>
Date:   Fri Sep 13 00:55:33 2024 +0900

    wip!: save

commit a580362
Author: Unique-Divine <[email protected]>
Date:   Thu Sep 12 09:55:48 2024 +0900

    chore: linter and changelog

commit 121287d
Merge: f92de5e 6ba79bb
Author: Unique-Divine <[email protected]>
Date:   Thu Sep 12 09:47:00 2024 +0900

    Merge branch 'main' into ud/2408/eth-rpc

commit f92de5e
Author: Unique-Divine <[email protected]>
Date:   Wed Sep 11 13:38:09 2024 +0900

    chore: changelog

commit 1390371
Merge: 0b4b39b 64beba7
Author: Unique-Divine <[email protected]>
Date:   Wed Sep 11 12:21:50 2024 +0900

    Merge branch 'main' into ud/2408/eth-rpc

commit 0b4b39b
Author: Unique-Divine <[email protected]>
Date:   Wed Sep 11 11:55:23 2024 +0900

    chore(github): Automate labeleing and add-to-project for GH issues/tickets

commit 94519d4
Author: Unique-Divine <[email protected]>
Date:   Tue Sep 10 23:29:48 2024 +0900

    pending chekcpoint

commit 563c253
Author: Unique-Divine <[email protected]>
Date:   Mon Sep 9 15:02:02 2024 +0900

    test(e2e): remove unnecessary skips

commit bb6cb20
Author: Unique-Divine <[email protected]>
Date:   Mon Sep 9 14:36:59 2024 +0900

    remove dead code

commit 97da983
Merge: 0868ce8 b1aac01
Author: Unique-Divine <[email protected]>
Date:   Mon Sep 9 14:28:59 2024 +0900

    Merge branch 'main' into ud/2408/eth-rpc

commit 0868ce8
Author: Unique-Divine <[email protected]>
Date:   Mon Sep 9 14:28:53 2024 +0900

    wip!: checkpoint
Copy link
Contributor

coderabbitai bot commented Sep 13, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 30 lines in your changes missing coverage. Please review.

Project coverage is 62.81%. Comparing base (0929266) to head (943b164).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
x/evm/events.go 22.72% 15 Missing and 2 partials ⚠️
eth/rpc/backend/utils.go 25.00% 9 Missing ⚠️
eth/rpc/backend/tx_info.go 83.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2037      +/-   ##
==========================================
- Coverage   62.89%   62.81%   -0.08%     
==========================================
  Files         266      267       +1     
  Lines       16826    16854      +28     
==========================================
+ Hits        10582    10587       +5     
- Misses       5434     5457      +23     
  Partials      810      810              
Files with missing lines Coverage Δ
eth/rpc/rpcapi/eth_api.go 39.26% <100.00%> (ø)
x/evm/keeper/msg_server.go 74.93% <100.00%> (+0.06%) ⬆️
eth/rpc/backend/tx_info.go 54.16% <83.33%> (+0.25%) ⬆️
eth/rpc/backend/utils.go 12.33% <25.00%> (-0.68%) ⬇️
x/evm/events.go 22.72% <22.72%> (ø)

@Unique-Divine Unique-Divine changed the title refactor(evm): Move the tx logs and message event to use typed events (for #2034) test(evm-rpc-backend): Add testnetwork tests using a node with a real RPC backend Sep 15, 2024
Unique-Divine added a commit that referenced this pull request Sep 17, 2024
…ompleting #2037 (#2041)

* refactor: partial commit from #2037. Remove mocks

* chore: changelog
@Unique-Divine
Copy link
Member Author

Changes included enough on a different PR. Closing this as unnecessary

@Unique-Divine Unique-Divine deleted the ud/evm-events branch October 1, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants