chore(deps): cometbft v0.37.5, cosmos-sdk v0.47.11, proto-builder v0.14.0 #1899
Conversation
WalkthroughThe recent updates primarily focus on upgrading build dependencies and improving the development workflow. Key changes include updating the Changes
Poem
Tip Early Access Features
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (4)
proto/buf.gen.rs.sh (4)
Line range hint
9-9: Ensure variables are properly quoted to prevent globbing and word splitting.- local start_path=$(pwd) - local start_dir_name=$(basename $start_path) + local start_path="$(pwd)" + local start_dir_name="$(basename "$start_path")"Also applies to: 10-10, 51-51
Line range hint
94-97: Ensure variables are properly quoted to prevent globbing and word splitting.- cosmos_sdk_gh_path=$(go list -f '{{ .Dir }}' -m github.com/cosmos/cosmos-sdk) - nibiru_cosmos_sdk_version=$(echo $cosmos_sdk_gh_path | awk -F'@' '{print $2}') + cosmos_sdk_gh_path="$(go list -f '{{ .Dir }}' -m github.com/cosmos/cosmos-sdk)" + nibiru_cosmos_sdk_version="$(echo "$cosmos_sdk_gh_path" | awk -F'@' '{print $2}')"
Line range hint
122-122: Correct the array expansion to include all elements.- echo "$proto_dirs" + echo "${proto_dirs[@]}"
Line range hint
155-156: Prevent potential dangerous directory deletion by ensuring variables are not empty.- rm -rf $OUT_PATH/home - rm -rf $OUT_PATH/nibiru + rm -rf "${OUT_PATH:?}/home" + rm -rf "${OUT_PATH:?}/nibiru"
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
go.modis excluded by!**/*.mod,!**/*.modgo.sumis excluded by!**/*.sum,!**/*.sum
Files selected for processing (3)
- CHANGELOG.md (1 hunks)
- contrib/make/proto.mk (2 hunks)
- proto/buf.gen.rs.sh (1 hunks)
Files skipped from review due to trivial changes (1)
- contrib/make/proto.mk
Additional Context Used
ShellCheck (20)
proto/buf.gen.rs.sh (20)
[warning] 9-9: Declare and assign separately to avoid masking return values.
[warning] 10-10: Declare and assign separately to avoid masking return values.
[info] 10-10: Double quote to prevent globbing and word splitting.
[info] 51-51: Double quote to prevent globbing and word splitting.
[info] 78-78: Double quote to prevent globbing and word splitting.
[error] 86-86: This expression is constant. Did you forget a $ somewhere?
[info] 94-94: Double quote to prevent globbing and word splitting.
[info] 95-95: Double quote to prevent globbing and word splitting.
[info] 96-96: Double quote to prevent globbing and word splitting.
[info] 97-97: Double quote to prevent globbing and word splitting.
[warning] 102-102: Declare and assign separately to avoid masking return values.
[info] 109-109: Double quote to prevent globbing and word splitting.
[info] 118-118: Double quote to prevent globbing and word splitting.
[warning] 122-122: Expanding an array without an index only gives the first element.
[info] 135-135: Double quote to prevent globbing and word splitting.
[info] 135-135: Double quote to prevent globbing and word splitting.
[info] 137-137: Double quote to prevent globbing and word splitting.
[warning] 155-155: Use "${var:?}" to ensure this never expands to /home .
[info] 155-155: Double quote to prevent globbing and word splitting.
[info] 156-156: Double quote to prevent globbing and word splitting.
Additional comments not posted (1)
CHANGELOG.md (1)
95-95: The changelog entry for PR #1899 correctly lists the dependency updates and is appropriately categorized under "Non-breaking/Compatible Improvements".
| @@ -84,7 +84,8 @@ buf_gen() { | |||
| local proto_dir="$1" | |||
|
|
|||
| if [ ! buf ]; then | |||
There was a problem hiding this comment.
Correct the syntax error in the conditional check for buf.
- if [ ! buf ]; then
+ if ! command -v buf &> /dev/null; thenCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| if [ ! buf ]; then | |
| if ! command -v buf &> /dev/null; then |
Purpose / Abstract