Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: epic(evm): End-to-end EVM contract tests, keeper logic, contract bytecode, EthCall, and Ethereum JSON-RPC coverage #1883

Merged
merged 26 commits into from
May 28, 2024

Conversation

Unique-Divine
Copy link
Member

@Unique-Divine Unique-Divine commented May 15, 2024

Purpose / Abstract

commit 1fe82fe
Merge: 4e323da fac6492
Author: Unique-Divine <[email protected]>
Date:   Tue May 14 23:48:32 2024 -0500

    Merge branch 'main' into on/evm-json-rpc

commit 4e323da
Author: Oleg Nikonychev <[email protected]>
Date:   Tue May 14 22:34:36 2024 +0400

    feat: implemented evm grpc_query params

commit ec64f33
Merge: eed9f8c 6e38c19
Author: Oleg Nikonychev <[email protected]>
Date:   Tue May 14 21:12:33 2024 +0400

    chore: resolve conflicts

commit eed9f8c
Author: Oleg Nikonychev <[email protected]>
Date:   Tue May 14 21:09:44 2024 +0400

    chore: changelog

commit e0ec526
Author: Oleg Nikonychev <[email protected]>
Date:   Tue May 14 21:08:07 2024 +0400

    chore: changelog

commit 6b5191b
Merge: 518e89f 69865ec
Author: Oleg Nikonychev <[email protected]>
Date:   Tue May 14 21:04:30 2024 +0400

    Merge branch 'ud/eth-2' into on/evm-json-rpc

commit 69865ec
Author: Unique-Divine <[email protected]>
Date:   Tue May 14 12:01:32 2024 -0500

    linter + changelog

commit 518e89f
Author: Oleg Nikonychev <[email protected]>
Date:   Tue May 14 21:00:30 2024 +0400

    fix: hacked eth chain id

commit f874b87
Author: Unique-Divine <[email protected]>
Date:   Tue May 14 11:54:19 2024 -0500

    query Balance

commit 289b1d7
Author: Unique-Divine <[email protected]>
Date:   Tue May 14 11:30:15 2024 -0500

    fix(deps): remove local collections replace statement

commit 2215a9a
Author: Oleg Nikonychev <[email protected]>
Date:   Tue May 14 20:16:58 2024 +0400

    chore: cleanup

commit 71d5179
Author: Oleg Nikonychev <[email protected]>
Date:   Tue May 14 20:15:12 2024 +0400

    feat: evm app config and json-rpc

commit fc5f463
Author: Unique-Divine <[email protected]>
Date:   Tue May 14 10:55:30 2024 -0500

    eth: query type validation

commit a6437fd
Merge: 0c5cffb 40a0a9a
Author: Unique-Divine <[email protected]>
Date:   Tue May 14 10:53:50 2024 -0500

    Merge branch 'ud/eth' into ud/eth-2

commit 0c5cffb
Author: Unique-Divine <[email protected]>
Date:   Tue May 14 10:53:46 2024 -0500

    chore(deps): use collections v0.5

commit 40a0a9a
Merge: 0dbba9e 2342254
Author: Unique-Divine <[email protected]>
Date:   Mon May 13 11:12:53 2024 -0500

    Merge branch 'main' into ud/eth

commit 0dbba9e
Author: Unique-Divine <[email protected]>
Date:   Mon May 13 11:12:42 2024 -0500

    quicksave wip!

commit 820f50e
Merge: 3159973 e7ed442
Author: Unique-Divine <[email protected]>
Date:   Fri May 10 02:42:51 2024 -0500

    Merge branch 'main' into ud/eth

commit 3159973
Author: Unique-Divine <[email protected]>
Date:   Fri May 10 02:41:42 2024 -0500

    feat(evm): module wiring
Copy link
Contributor

coderabbitai bot commented May 15, 2024

Important

Review Skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

37 files out of 94 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Tip

Early Access Features
  • gpt-4o model for chat

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to full the review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 38.26087% with 1065 lines in your changes are missing coverage. Please review.

Project coverage is 62.13%. Comparing base (9c7d8ce) to head (469c7aa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1883      +/-   ##
==========================================
- Coverage   67.37%   62.13%   -5.24%     
==========================================
  Files         218      245      +27     
  Lines       13641    16006    +2365     
==========================================
+ Hits         9191     9946     +755     
- Misses       3790     5323    +1533     
- Partials      660      737      +77     
Files Coverage Δ
app/appconst/appconst.go 57.14% <100.00%> (ø)
app/keepers.go 99.16% <100.00%> (+<0.01%) ⬆️
eth/eip712/encoding.go 77.19% <100.00%> (-3.51%) ⬇️
eth/eip712/encoding_legacy.go 76.47% <100.00%> (-2.95%) ⬇️
eth/gas_limit.go 100.00% <100.00%> (ø)
eth/rpc/backend/backend.go 75.00% <100.00%> (ø)
eth/rpc/backend/call_tx.go 61.18% <100.00%> (ø)
eth/rpc/backend/chain_info.go 81.98% <100.00%> (ø)
eth/rpc/rpcapi/net_api.go 23.80% <100.00%> (ø)
x/common/constants.go 0.00% <ø> (ø)
... and 39 more

... and 8 files with indirect coverage changes

Unique-Divine and others added 23 commits May 15, 2024 01:24
* feat: implemented basic evm tx methods

* chore: lint

* chore: extracted evm chain_id to appconst

* fix: tests

* fix: tests

* fix: lint

* chore: cleanup

* refactor: merge upstream

* chore(evm-keeper): remove unused code

---------

Co-authored-by: Unique-Divine <[email protected]>
* test(evm): eth api integration test suite

* test(evm): more integration tests for eth api

* feat: implemented basic evm tx methods

* chore: lint

* chore: lint

* chore: lint

* chore: extracted evm chain_id to appconst

* fix: tests

* fix: tests

* fix: lint

* chore: cleanup

* refactor: merge

* fix: eth chain ID test

* fix(eth): chain ID

* linter fix

* test(evm): integration tests for tx and smart contract

* chore(evm): disabled json rpc by default

* refactor: merge conflicts

* test(rpcapi): make fixtures consistent

* fix(evm): integration test fixture setup

* chore: linter

---------

Co-authored-by: Unique-Divine <[email protected]>
* test(evm): eth api integration test suite

* test(evm): more integration tests for eth api

* feat: implemented basic evm tx methods

* chore: lint

* chore: lint

* chore: lint

* chore: extracted evm chain_id to appconst

* fix: tests

* fix: tests

* fix: lint

* chore: cleanup

* refactor: merge

* fix: eth chain ID test

* fix(eth): chain ID

* linter fix

* test(evm): integration tests for tx and smart contract

* chore(evm): disabled json rpc by default

* test(evm): ethers.js tests for evm

* test(evm): github workflow

* fix: gh actions evm tests npm instead of yarn

* fix: evm gh tests

* fix: evm gh tests

* fix: evm gh tests

* chore: cleanup

* chore: renamed evm job

* refactor: merge conflict rever

* refactor(e2e): consistent path

* chore: cleanup unused

* wip!: try removing chain ID hacks

* wip!: try removing chain ID hacks

* chore: linter

---------

Co-authored-by: Unique-Divine <[email protected]>
@Unique-Divine Unique-Divine changed the title feat(evm): keeper logic for ValidatorAccount, BaseFee, contract bytecode, EthCall, etc. epic(evm): End-to-end EVM contract tests, keeper logic, contract bytecode, EthCall, and Ethereum JSON-RPC coverage May 27, 2024
@Unique-Divine Unique-Divine changed the title epic(evm): End-to-end EVM contract tests, keeper logic, contract bytecode, EthCall, and Ethereum JSON-RPC coverage feat: epic(evm): End-to-end EVM contract tests, keeper logic, contract bytecode, EthCall, and Ethereum JSON-RPC coverage May 28, 2024
@Unique-Divine Unique-Divine added x: evm Relates to Nibiru EVM or the EVM Module type: tests epic Project or large task that groups multiple tickets and PRs labels May 28, 2024
@Unique-Divine Unique-Divine marked this pull request as ready for review May 28, 2024 02:26
@Unique-Divine Unique-Divine requested a review from a team as a code owner May 28, 2024 02:26
@Unique-Divine Unique-Divine merged commit 4d4205a into main May 28, 2024
28 of 29 checks passed
@Unique-Divine Unique-Divine deleted the ud/eth branch May 28, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic Project or large task that groups multiple tickets and PRs x: evm Relates to Nibiru EVM or the EVM Module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants