feat: add new field capacityPerPool to capacity pool API #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rackstar
force-pushed
the
feat/staking-data-product-pricing-per-pool
branch
2 times, most recently
from
9337fb9
to
d8e7aa8
Compare
rackstar
changed the title
rackstar
changed the base branch from
dev
to
feat/staking-data-pool-detailed-capacity
rackstar
force-pushed
the
feat/staking-data-pool-detailed-capacity
branch
from
999a544
to
b73a66b
Compare
rackstar
force-pushed
the
feat/staking-data-product-pricing-per-pool
branch
from
d8e7aa8
to
c5fda65
Compare
rackstar
commented
Oct 11, 2024
Comment on lines
+66
to
+73
| function calculateProductDataForTranche(productPools, firstUsableTrancheIndex, useFixedPrice, now, assets, assetRates) { | ||
| const aggregatedData = { | ||
| capacityUsedNXM: Zero, | ||
| capacityAvailableNXM: Zero, | ||
| minPrice: Zero, | ||
| totalPremium: Zero, | ||
| }; | ||
|
|
||
| const capacityPerPool = productPools.map(pool => { |
There was a problem hiding this comment.
The main change here is adding capacityPerPool to the result along with the previous aggregatedData return value
TeriThetha
approved these changes
Oct 30, 2024
TeriThetha
approved these changes
Oct 30, 2024
TeriThetha
approved these changes
Oct 30, 2024
TeriThetha
approved these changes
Oct 30, 2024
TeriThetha
approved these changes
Oct 30, 2024
rackstar
force-pushed
the
feat/staking-data-pool-detailed-capacity
branch
from
b73a66b
to
f117f00
Compare
rackstar
force-pushed
the
feat/staking-data-product-pricing-per-pool
branch
from
b0f4aa8
to
8683c06
Compare
rackstar
changed the title
rackstar
force-pushed
the
feat/staking-data-product-pricing-per-pool
branch
from
8683c06
to
213f5d3
Compare
MilGard91
reviewed
Nov 19, 2024
| totalPremium, | ||
| }; | ||
| } | ||
| function calculateProductDataForTranche(productPools, firstUsableTrancheIndex, useFixedPrice, now, assets, assetRates) { |
There was a problem hiding this comment.
I would remove assets and assetRates from this function, as I can see we are not using availableCapacityInAssets for anything and we are recalculating it again later in the code
There was a problem hiding this comment.
the availableCapacityInAssets in this function is under capacityPerPool field, meaning the value is segregated by StakingPool.
on the other hand the 2nd capacityInAssets (on capacityEngine function) is the value across all StakingPools.
* add calculateAvailableCapacity
* remove code duplication in capacityEngine
* capacityPerPools unit tests if withPools=true * calculateProductDataForTranche * calculateAvailableCapacity * getProductsInPool * calculateTrancheInfo
* capacityPerPool field unit test
rackstar
force-pushed
the
feat/staking-data-product-pricing-per-pool
branch
from
cb34d60
to
72c5c26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #131
/capacity/:pooId:capacityPerPoolfield object - min/maxAnnualPrice for a product per poolNOTE: this PR is behind #130
Testing
unit tests
Checklist