Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loadorder v2 tree data grid backend part 6 #2323

Merged
merged 18 commits into from
Dec 2, 2024
Merged

Loadorder v2 tree data grid backend part 6 #2323

merged 18 commits into from
Dec 2, 2024
+255 −102

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented Nov 28, 2024

Details:

  • Added support for switching sort direction
  • Updated Up/Down buttons to work in inverted direction
  • Updated Up/Down Commands to use MessageSubject to defer implementation to parent VM
  • Update ApplyChanges() to attempt to keep sorting information when populating ObservableList
  • Fixed Trophy gradient classes not being cleared correctly
  • Fixed Alert settings key not being specific to current load order type

@Al12rs
Add bindings for SortDirection combobox
d314526
@Al12rs
Pass in necessary observables for UP/Down commands
9449ac5
@Al12rs
Implement canExecute for commands
4b447a6
@Al12rs
Setup up/down command to trigger the messageSubject
c447003
@Al12rs
Use R3 Units for R3.ReactiveCommands
5d32037
@Al12rs
Make Up/Down buttons work with different sort directions
4b3115c
@Al12rs
Merge branch 'main' into loadorder-v2-TreeDataGrid-backend
9b698dd 
# Conflicts:
#	src/NexusMods.App.UI/Pages/Sorting/LoadOrder/LoadOrderView.axaml
#	src/NexusMods.App.UI/Pages/Sorting/LoadOrder/LoadOrderView.axaml.cs
#	src/NexusMods.App.UI/Pages/Sorting/LoadOrder/LoadOrderViewModel.cs
@Al12rs
Remove sorting workaround
6f33b56
@Al12rs
ObservableList ApplyChanges: insert items at provided index positions…
06fb4ec 
… to maintain sorting
@Al12rs
Use sorted changesets depending on sortDirection, but still doesn't work
4239f21
@Al12rs
Use Sort to sort the changeset before sending it off, to avoid the Sw…
1f9f178 
…itch removing the sort daata
@Al12rs
Finally fix the sorting
abcc981
@Al12rs
Fix trophy gradient classes not being removed correctly on switch
8a6e2e1
@Al12rs
Use different keys for different load orders to save the Alert dismis…
6bdfd07 
…s state
@Al12rs Al12rs requested a review from a team November 28, 2024 16:22
@Al12rs Al12rs self-assigned this Nov 28, 2024
@insomnious insomnious self-requested a review December 2, 2024 11:02
@Al12rs Al12rs merged commit f90e63f into main Dec 2, 2024
11 checks passed
@Al12rs Al12rs deleted the loadorder-v2-TreeDataGrid-backend branch December 2, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@insomnious insomnious insomnious approved these changes

Assignees

@Al12rs Al12rs

Labels
None yet
Projects
MVP
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Al12rs @insomnious