Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/24 : 관리자 글귀 수정 API #30

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Feature/24 : 관리자 글귀 수정 API #30

merged 4 commits into from
Jan 30, 2024

Conversation

shincheeun
Copy link
Collaborator

@shincheeun shincheeun commented Jan 28, 2024 •
edited
Loading

🚀 개요

관리자(백오피스) 글귀 수정 기능

🔍 작업 내용

  • PATCH /admin/phrases/{id} 글귀 수정
  • phraseId를 사용하여 관리자(백오피스)의 글을 수정합니다.

📝 논의사항

  • 단건의 이미지(request) 수정만 가능하게 구현되어 있어, 여러 건의 이미지 수정 요청이 오는 경우는 추후 고도화 하려고 합니다. cf. 글귀 등록도 마찬가지 입니다.
  • 이 경우 request에서 글귀(title, content) / 이미지(filename, imageratio)를 분리해서 이미지만 여러개의 변수가 온다고 가정해야 할것 같습니다.

@shincheeun shincheeun linked an issue Jan 28, 2024 that may be closed by this pull request
🚀 [feature] 관리자 글귀 수정 API #27
Closed
@shincheeun shincheeun added the feature New feature or request label Jan 28, 2024
@shincheeun shincheeun changed the title Feature/27 Feature/24 관리자 글귀 수정 API Jan 28, 2024
@swa07016 swa07016 changed the title Feature/24 관리자 글귀 수정 API Feature/24 : 관리자 글귀 수정 API Jan 28, 2024
@swa07016
Copy link
Member

#33
해당 PR의 리뷰 내용과 동일합니다:)

@shincheeun shincheeun merged commit b53cae6 into develop Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swa07016 swa07016 swa07016 approved these changes

Assignees

@shincheeun shincheeun

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 [feature] 관리자 글귀 수정 API
2 participants
@shincheeun @swa07016