Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/173 : API 응답 필드 제외 #174

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Feature/173 : API 응답 필드 제외 #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/nexters/dailyphrase/prize/business/PrizeEventMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public PrizeEventResponseDTO.PrizeEventInfo toPrizeEventInfo(PrizeEvent prizeEve
.eventStartDateTime(prizeEvent.getStartAt())
.eventEndDateTime(prizeEvent.getEndAt())
.eventWinnerAnnouncementDateTime(prizeEvent.getWinnerAnnouncementAt())
.status(prizeEvent.getStatus().getDescription())
// .status(prizeEvent.getStatus().getDescription())
.build();
}

Expand Down
9 changes: 0 additions & 9 deletions src/main/java/com/nexters/dailyphrase/prize/domain/repository/PrizeCustomRepositoryImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import static com.nexters.dailyphrase.common.enums.PrizeTicketStatus.AVAILABLE;

import java.time.LocalDateTime;
import java.util.List;

import org.springframework.stereotype.Repository;
Expand Down Expand Up @@ -86,17 +85,9 @@ public PrizeEventResponseDTO.PrizeList findPrizeListDTO(Long eventId) {
.where(qPrize.event.id.eq(eventId))
.fetch();

LocalDateTime eventEndDateTime =
queryFactory
.select(qPrizeEvent.endAt)
.from(qPrizeEvent)
.where(qPrizeEvent.id.eq(eventId))
.fetchOne();

return PrizeEventResponseDTO.PrizeList.builder()
.total(prizeListItems.size())
.prizeList(prizeListItems)
.eventEndDateTime(eventEndDateTime)
.build();
}
}
3 changes: 1 addition & 2 deletions src/main/java/com/nexters/dailyphrase/prize/presentation/dto/PrizeEventResponseDTO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ public static class PrizeListItem {
public static class PrizeList {
private long total;
@Builder.Default private List<PrizeListItem> prizeList = new ArrayList<>();
private LocalDateTime eventEndDateTime;
}

@Builder
Expand Down Expand Up @@ -85,7 +84,7 @@ public static class PrizeEventInfo {
private LocalDateTime eventStartDateTime;
private LocalDateTime eventEndDateTime;
private LocalDateTime eventWinnerAnnouncementDateTime;
private String status;
// private String status;
}

@Builder
Expand Down
Loading